Re: [Mesa-dev] [PATCH] radv: Change memory type order for GPUs without dedicated VRAM

2019-06-12 Thread Alex Smith
On Tue, 11 Jun 2019 at 14:32, Christian König < ckoenig.leichtzumer...@gmail.com> wrote: > Am 10.06.19 um 15:56 schrieb Bas Nieuwenhuizen: > > On Sat, Jun 8, 2019 at 3:36 PM Alex Smith > wrote: > >> On Mon, 3 Jun 2019 at 13:27, Koenig, Christian < > christian.koe...@amd.com> wrote: > >>> Am

Re: [Mesa-dev] [PATCH] radv: Change memory type order for GPUs without dedicated VRAM

2019-06-11 Thread Christian König
Am 10.06.19 um 15:56 schrieb Bas Nieuwenhuizen: On Sat, Jun 8, 2019 at 3:36 PM Alex Smith wrote: On Mon, 3 Jun 2019 at 13:27, Koenig, Christian wrote: Am 03.06.19 um 14:21 schrieb Alex Smith: On Mon, 3 Jun 2019 at 11:57, Koenig, Christian wrote: Am 02.06.19 um 12:32 schrieb Alex Smith:

Re: [Mesa-dev] [PATCH] radv: Change memory type order for GPUs without dedicated VRAM

2019-06-10 Thread Bas Nieuwenhuizen
On Sat, Jun 8, 2019 at 3:36 PM Alex Smith wrote: > > On Mon, 3 Jun 2019 at 13:27, Koenig, Christian > wrote: >> >> Am 03.06.19 um 14:21 schrieb Alex Smith: >> >> On Mon, 3 Jun 2019 at 11:57, Koenig, Christian >> wrote: >>> >>> Am 02.06.19 um 12:32 schrieb Alex Smith: >>> > Put the uncached

Re: [Mesa-dev] [PATCH] radv: Change memory type order for GPUs without dedicated VRAM

2019-06-08 Thread Alex Smith
On Mon, 3 Jun 2019 at 13:27, Koenig, Christian wrote: > Am 03.06.19 um 14:21 schrieb Alex Smith: > > On Mon, 3 Jun 2019 at 11:57, Koenig, Christian > wrote: > >> Am 02.06.19 um 12:32 schrieb Alex Smith: >> > Put the uncached GTT type at a higher index than the visible VRAM type, >> > rather

Re: [Mesa-dev] [PATCH] radv: Change memory type order for GPUs without dedicated VRAM

2019-06-03 Thread Alex Smith
Thanks, will have a look - can't look right now, will see if I can sometime tomorrow. Alex On Mon, 3 Jun 2019 at 13:27, Koenig, Christian wrote: > Am 03.06.19 um 14:21 schrieb Alex Smith: > > On Mon, 3 Jun 2019 at 11:57, Koenig, Christian > wrote: > >> Am 02.06.19 um 12:32 schrieb Alex Smith:

Re: [Mesa-dev] [PATCH] radv: Change memory type order for GPUs without dedicated VRAM

2019-06-03 Thread Koenig, Christian
Am 03.06.19 um 14:21 schrieb Alex Smith: On Mon, 3 Jun 2019 at 11:57, Koenig, Christian mailto:christian.koe...@amd.com>> wrote: Am 02.06.19 um 12:32 schrieb Alex Smith: > Put the uncached GTT type at a higher index than the visible VRAM type, > rather than having GTT first. > > When we don't

Re: [Mesa-dev] [PATCH] radv: Change memory type order for GPUs without dedicated VRAM

2019-06-03 Thread Alex Smith
On Mon, 3 Jun 2019 at 11:57, Koenig, Christian wrote: > Am 02.06.19 um 12:32 schrieb Alex Smith: > > Put the uncached GTT type at a higher index than the visible VRAM type, > > rather than having GTT first. > > > > When we don't have dedicated VRAM, we don't have a non-visible VRAM > > type, and

Re: [Mesa-dev] [PATCH] radv: Change memory type order for GPUs without dedicated VRAM

2019-06-03 Thread Koenig, Christian
Am 02.06.19 um 12:32 schrieb Alex Smith: > Put the uncached GTT type at a higher index than the visible VRAM type, > rather than having GTT first. > > When we don't have dedicated VRAM, we don't have a non-visible VRAM > type, and the property flags for GTT and visible VRAM are identical. >

Re: [Mesa-dev] [PATCH] radv: Change memory type order for GPUs without dedicated VRAM

2019-06-03 Thread Samuel Pitoiset
On 6/3/19 9:46 AM, Alex Smith wrote: On Sun, 2 Jun 2019 at 11:59, Bas Nieuwenhuizen mailto:b...@basnieuwenhuizen.nl>> wrote: On Sun, Jun 2, 2019 at 12:32 PM Alex Smith mailto:asm...@feralinteractive.com>> wrote: > > Put the uncached GTT type at a higher index than the

Re: [Mesa-dev] [PATCH] radv: Change memory type order for GPUs without dedicated VRAM

2019-06-03 Thread Alex Smith
On Sun, 2 Jun 2019 at 11:59, Bas Nieuwenhuizen wrote: > On Sun, Jun 2, 2019 at 12:32 PM Alex Smith > wrote: > > > > Put the uncached GTT type at a higher index than the visible VRAM type, > > rather than having GTT first. > > > > When we don't have dedicated VRAM, we don't have a non-visible

Re: [Mesa-dev] [PATCH] radv: Change memory type order for GPUs without dedicated VRAM

2019-06-03 Thread Samuel Pitoiset
Reviewed-by: Samuel Pitoiset On 6/2/19 12:32 PM, Alex Smith wrote: Put the uncached GTT type at a higher index than the visible VRAM type, rather than having GTT first. When we don't have dedicated VRAM, we don't have a non-visible VRAM type, and the property flags for GTT and visible VRAM

Re: [Mesa-dev] [PATCH] radv: Change memory type order for GPUs without dedicated VRAM

2019-06-02 Thread Bas Nieuwenhuizen
On Sun, Jun 2, 2019 at 12:32 PM Alex Smith wrote: > > Put the uncached GTT type at a higher index than the visible VRAM type, > rather than having GTT first. > > When we don't have dedicated VRAM, we don't have a non-visible VRAM > type, and the property flags for GTT and visible VRAM are

[Mesa-dev] [PATCH] radv: Change memory type order for GPUs without dedicated VRAM

2019-06-02 Thread Alex Smith
Put the uncached GTT type at a higher index than the visible VRAM type, rather than having GTT first. When we don't have dedicated VRAM, we don't have a non-visible VRAM type, and the property flags for GTT and visible VRAM are identical. According to the spec, for types with identical flags, we