Re: [Mesa-dev] [PATCH] radv: Implement VK_EXT_vertex_attribute_divisor.

2018-04-12 Thread Bas Nieuwenhuizen
Test test to the list. On Thu, Apr 12, 2018 at 9:28 AM, Samuel Pitoiset wrote: > Looks good to me, do you have tests? > > Reviewed-by: Samuel Pitoiset > > > On 04/12/2018 01:45 AM, Bas Nieuwenhuizen wrote: >> >> Pretty straight forward, just

Re: [Mesa-dev] [PATCH] radv: Implement VK_EXT_vertex_attribute_divisor.

2018-04-12 Thread Samuel Pitoiset
Looks good to me, do you have tests? Reviewed-by: Samuel Pitoiset On 04/12/2018 01:45 AM, Bas Nieuwenhuizen wrote: Pretty straight forward, just pass the divisors through the shader key and then do a LLVM divide. --- src/amd/vulkan/radv_device.c | 6 ++

[Mesa-dev] [PATCH] radv: Implement VK_EXT_vertex_attribute_divisor.

2018-04-11 Thread Bas Nieuwenhuizen
Pretty straight forward, just pass the divisors through the shader key and then do a LLVM divide. --- src/amd/vulkan/radv_device.c | 6 ++ src/amd/vulkan/radv_extensions.py | 1 + src/amd/vulkan/radv_nir_to_llvm.c | 26 +++--- src/amd/vulkan/radv_pipeline.c| 26