LGTM.
Thanks for double checking Tim!
On 5/8/19 1:27 AM, Timothy Arceri wrote:
On 8/5/19 1:51 am, Samuel Pitoiset wrote:
What games are affected btw?
PERCENTAGE DELTAS Shaders SGPRs VGPRs SpillSGPR CodeSize
MaxWaves
batman-arkham-city 2581 . . . .
On 8/5/19 1:51 am, Samuel Pitoiset wrote:
What games are affected btw?
PERCENTAGE DELTASShaders SGPRs VGPRs SpillSGPR CodeSize
MaxWaves
batman-arkham-city 2581 . . .. .
dawn-of-war-3 244 . . ..
What games are affected btw?
Can you please double check before pushing because of the flrp changes
that landed around?
On 5/7/19 7:14 AM, Timothy Arceri wrote:
ping!
On 2/5/19 1:38 pm, Timothy Arceri wrote:
The pattern of calling opt algebraic first seems to have originated
in i965. The
Nope, r-b
On Tue, May 7, 2019 at 8:36 AM Samuel Pitoiset
wrote:
>
> Seems fine to,
>
> Reviewed-by: Samuel Pitoiset
>
> Bas, any comments?
>
> On 5/7/19 7:14 AM, Timothy Arceri wrote:
> > ping!
> >
> > On 2/5/19 1:38 pm, Timothy Arceri wrote:
> >> The pattern of calling opt algebraic first
Seems fine to,
Reviewed-by: Samuel Pitoiset
Bas, any comments?
On 5/7/19 7:14 AM, Timothy Arceri wrote:
ping!
On 2/5/19 1:38 pm, Timothy Arceri wrote:
The pattern of calling opt algebraic first seems to have originated
in i965. The order in OpenGL drivers generally doesn't matter
because
ping!
On 2/5/19 1:38 pm, Timothy Arceri wrote:
The pattern of calling opt algebraic first seems to have originated
in i965. The order in OpenGL drivers generally doesn't matter
because the GLSL IR optimisations do constant folding before
opt algebraic.
However in Vulkan drivers calling opt
The pattern of calling opt algebraic first seems to have originated
in i965. The order in OpenGL drivers generally doesn't matter
because the GLSL IR optimisations do constant folding before
opt algebraic.
However in Vulkan drivers calling opt algebraic first can result
in missed constant folding
