Re: [Mesa-dev] [PATCH] radv: fix resource leak in radv_amdgpu_ctx_create

2016-12-05 Thread Nayan Deshmukh
Thanks for the review. Can you push the patch for me.

Regards,
Nayan

On Mon, Dec 5, 2016 at 2:46 PM, Edward O'Callaghan
 wrote:
> Reviewed-by: Edward O'Callaghan 
>
> On 12/05/2016 04:45 AM, Nayan Deshmukh wrote:
>> CovID: 1396387
>>
>> Signed-off-by: Nayan Deshmukh 
>> ---
>>  src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c 
>> b/src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c
>> index b8558fa..08abb9d 100644
>> --- a/src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c
>> +++ b/src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c
>> @@ -742,6 +742,7 @@ static struct radeon_winsys_ctx 
>> *radv_amdgpu_ctx_create(struct radeon_winsys *_w
>>   ctx->ws = ws;
>>   return (struct radeon_winsys_ctx *)ctx;
>>  error_create:
>> +FREE(ctx);
>>   return NULL;
>>  }
>>
>>
>
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev


Re: [Mesa-dev] [PATCH] radv: fix resource leak in radv_amdgpu_ctx_create

2016-12-05 Thread Edward O'Callaghan
Reviewed-by: Edward O'Callaghan 

On 12/05/2016 04:45 AM, Nayan Deshmukh wrote:
> CovID: 1396387
> 
> Signed-off-by: Nayan Deshmukh 
> ---
>  src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c 
> b/src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c
> index b8558fa..08abb9d 100644
> --- a/src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c
> +++ b/src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c
> @@ -742,6 +742,7 @@ static struct radeon_winsys_ctx 
> *radv_amdgpu_ctx_create(struct radeon_winsys *_w
>   ctx->ws = ws;
>   return (struct radeon_winsys_ctx *)ctx;
>  error_create:
> +FREE(ctx);
>   return NULL;
>  }
>  
> 



signature.asc
Description: OpenPGP digital signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev


[Mesa-dev] [PATCH] radv: fix resource leak in radv_amdgpu_ctx_create

2016-12-04 Thread Nayan Deshmukh
CovID: 1396387

Signed-off-by: Nayan Deshmukh 
---
 src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c 
b/src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c
index b8558fa..08abb9d 100644
--- a/src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c
+++ b/src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c
@@ -742,6 +742,7 @@ static struct radeon_winsys_ctx 
*radv_amdgpu_ctx_create(struct radeon_winsys *_w
ctx->ws = ws;
return (struct radeon_winsys_ctx *)ctx;
 error_create:
+FREE(ctx);
return NULL;
 }
 
-- 
2.9.3

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev