Re: [Mesa-dev] [PATCH] radv: fix the NUM_RECORDS field for vertex bindings on GFX6/GFX7

2019-03-18 Thread Bas Nieuwenhuizen
I think this needs to be modified to get the vulkan out of bounds behavior. In particular whether a VS input is out of bounds or not can differ between attributes from the same buffer with the same index, and that is something not handled here. I guess we could fix by only using the offset in

[Mesa-dev] [PATCH] radv: fix the NUM_RECORDS field for vertex bindings on GFX6/GFX7

2019-03-13 Thread Samuel Pitoiset
Since the driver now uses typed buffer loads, we don't have to account for the format. This fixes few CTS regressions on SI. Fixes: a66b186bebf ("radv: use typed buffer loads for vertex input fetches") Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 3 +--