Re: [Mesa-dev] [PATCH] radv: prevent dirtying of dynamic state when it does not change

2019-01-16 Thread Samuel Pitoiset
I wrote a similar patch in the past but I didn't notice any improvements. Though, as we already check state changes in some other places, I think it's better to be consistent. With the TODO comment removed, patch is: Reviewed-by: Samuel Pitoiset On 1/15/19 10:59 PM, Rhys Perry wrote: DXVK

Re: [Mesa-dev] [PATCH] radv: prevent dirtying of dynamic state when it does not change

2019-01-15 Thread Rhys Perry
I misread some code and forgot to remove it. It was always unrelated to this patch. On Wed, 16 Jan 2019 at 00:22, Bas Nieuwenhuizen wrote: > > On Tue, Jan 15, 2019 at 10:59 PM Rhys Perry wrote: > > > > DXVK often sets dynamic state without actually changing it. > > > > Signed-off-by: Rhys

Re: [Mesa-dev] [PATCH] radv: prevent dirtying of dynamic state when it does not change

2019-01-15 Thread Bas Nieuwenhuizen
On Tue, Jan 15, 2019 at 10:59 PM Rhys Perry wrote: > > DXVK often sets dynamic state without actually changing it. > > Signed-off-by: Rhys Perry > --- > src/amd/vulkan/radv_cmd_buffer.c | 92 ++-- > 1 file changed, 76 insertions(+), 16 deletions(-) > > diff --git

[Mesa-dev] [PATCH] radv: prevent dirtying of dynamic state when it does not change

2019-01-15 Thread Rhys Perry
DXVK often sets dynamic state without actually changing it. Signed-off-by: Rhys Perry --- src/amd/vulkan/radv_cmd_buffer.c | 92 ++-- 1 file changed, 76 insertions(+), 16 deletions(-) diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c