Re: [Mesa-dev] [PATCH] radv: skip updating clear/color metadata for conditional rendering

2019-03-28 Thread Samuel Pitoiset
On 3/28/19 12:31 PM, Bas Nieuwenhuizen wrote: r-b, though technically you may want something older for the fixes tag. Pushed with a "cc 19.0" tag instead. On Thu, Mar 28, 2019 at 12:20 PM Samuel Pitoiset wrote: I don't think we should update metadata when conditional rendering is

Re: [Mesa-dev] [PATCH] radv: skip updating clear/color metadata for conditional rendering

2019-03-28 Thread Bas Nieuwenhuizen
r-b, though technically you may want something older for the fixes tag. On Thu, Mar 28, 2019 at 12:20 PM Samuel Pitoiset wrote: > > I don't think we should update metadata when conditional rendering > is enabled. For some reasons, some CTS breaks only on SI. > > This fixes the following CTS on

[Mesa-dev] [PATCH] radv: skip updating clear/color metadata for conditional rendering

2019-03-28 Thread Samuel Pitoiset
I don't think we should update metadata when conditional rendering is enabled. For some reasons, some CTS breaks only on SI. This fixes the following CTS on SI: dEQP-VK.conditional_rendering.draw_clear.clear.depth.* Fixes: a777c3d7cb0 ("radv: Use correct image view comparison for fast clears.")