Re: [Mesa-dev] [PATCH] radv: take LDS into account for compute shader occupancy stats

2019-02-01 Thread Samuel Pitoiset
Fixed. On 2/1/19 2:57 PM, Mike Lothian wrote: Hi I think you've left a few references to the old ac_nir_get_max_workgroup_size FAILED: src/amd/vulkan/9198681@@vulkan_radeon@sha/radv_nir_to_llvm.c.o x86_64-pc-linux-gnu-gcc -m32 -Isrc/amd/vulkan/9198681@@vulkan_radeon@sha -Isrc/amd/vulkan

Re: [Mesa-dev] [PATCH] radv: take LDS into account for compute shader occupancy stats

2019-02-01 Thread Mike Lothian
Hi I think you've left a few references to the old ac_nir_get_max_workgroup_size FAILED: src/amd/vulkan/9198681@@vulkan_radeon@sha/radv_nir_to_llvm.c.o x86_64-pc-linux-gnu-gcc -m32 -Isrc/amd/vulkan/9198681@@vulkan_radeon@sha -Isrc/amd/vulkan -I../mesa-/src/amd/vulkan -Isrc/../include

Re: [Mesa-dev] [PATCH] radv: take LDS into account for compute shader occupancy stats

2019-02-01 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen On Fri, Feb 1, 2019 at 12:07 PM Timothy Arceri wrote: > > Ported from d205faeb6c96. > --- > src/amd/vulkan/radv_nir_to_llvm.c | 6 +++--- > src/amd/vulkan/radv_private.h | 3 +++ > src/amd/vulkan/radv_shader.c | 10 -- > 3 files changed, 14

[Mesa-dev] [PATCH] radv: take LDS into account for compute shader occupancy stats

2019-02-01 Thread Timothy Arceri
Ported from d205faeb6c96. --- src/amd/vulkan/radv_nir_to_llvm.c | 6 +++--- src/amd/vulkan/radv_private.h | 3 +++ src/amd/vulkan/radv_shader.c | 10 -- 3 files changed, 14 insertions(+), 5 deletions(-) diff --git a/src/amd/vulkan/radv_nir_to_llvm.c