Re: [Mesa-dev] [PATCH] spirv: split constant initializers on in/out structs

2018-02-05 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand On Tue, Jan 23, 2018 at 5:11 AM, Iago Toral Quiroga wrote: > The SPIR-V parser splits in/out struct variables and creates > a separate variable for each first-level member of the struct. > When the struct variable has an

Re: [Mesa-dev] [PATCH] spirv: split constant initializers on in/out structs

2018-02-04 Thread Iago Toral
This is still unreviewed. Jason, since you reviewed the other patch I sent related to output initializers, could you have a look at this one too? Iago On Tue, 2018-01-23 at 14:11 +0100, Iago Toral Quiroga wrote: > The SPIR-V parser splits in/out struct variables and creates > a separate

Re: [Mesa-dev] [PATCH] spirv: split constant initializers on in/out structs

2018-01-29 Thread Iago Toral
Anyone willing to review this? On Tue, 2018-01-23 at 14:11 +0100, Iago Toral Quiroga wrote: > The SPIR-V parser splits in/out struct variables and creates > a separate variable for each first-level member of the struct. > When the struct variable has an initializer this means that we also > need

[Mesa-dev] [PATCH] spirv: split constant initializers on in/out structs

2018-01-23 Thread Iago Toral Quiroga
The SPIR-V parser splits in/out struct variables and creates a separate variable for each first-level member of the struct. When the struct variable has an initializer this means that we also need to split the initializer. --- src/compiler/spirv/vtn_variables.c | 8 1 file changed, 8