Re: [Mesa-dev] [PATCH] st/mesa: fix the unconditional return in st_framebuffer_iface_remove

[Bas Nieuwenhuizen]

Per  https://www.mesa3d.org/submittingpatches.html, just a Fixes tag
should be enough to get in all the stable branches that still get
updated and contain the commit that is referenced.

- Bas

On Tue, Jul 25, 2017 at 8:55 PM, Marek Olšák  wrote:
> I've already sent a patch for this bug, but in the future, please mark
> all patches that should be in stable by adding the proper Cc tag.
>
> Thanks,
> Marek
>
> On Tue, Jul 25, 2017 at 2:00 AM, Charmaine Lee  wrote:
>> Fixes: bbc29393d3beaf6344c7188547b4ff61b63946ae
>> Tested-by: Christoph Haag 
>> ---
>>  src/mesa/state_tracker/st_manager.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/src/mesa/state_tracker/st_manager.c 
>> b/src/mesa/state_tracker/st_manager.c
>> index 834bcc9..6447403 100644
>> --- a/src/mesa/state_tracker/st_manager.c
>> +++ b/src/mesa/state_tracker/st_manager.c
>> @@ -560,7 +560,7 @@ st_framebuffer_iface_remove(struct st_manager *smapi,
>>(struct st_manager_private *)smapi->st_manager_private;
>> struct hash_entry *entry;
>>
>> -   if (!smPriv || !smPriv->stfbi_ht);
>> +   if (!smPriv || !smPriv->stfbi_ht)
>>return;
>>
>> mtx_lock(>st_mutex);
>> --
>> 1.9.1
>>
>> ___
>> mesa-dev mailing list
>> mesa-dev@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] st/mesa: fix the unconditional return in st_framebuffer_iface_remove

[Marek Olšák]

I've already sent a patch for this bug, but in the future, please mark
all patches that should be in stable by adding the proper Cc tag.

Thanks,
Marek

On Tue, Jul 25, 2017 at 2:00 AM, Charmaine Lee  wrote:
> Fixes: bbc29393d3beaf6344c7188547b4ff61b63946ae
> Tested-by: Christoph Haag 
> ---
>  src/mesa/state_tracker/st_manager.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/mesa/state_tracker/st_manager.c 
> b/src/mesa/state_tracker/st_manager.c
> index 834bcc9..6447403 100644
> --- a/src/mesa/state_tracker/st_manager.c
> +++ b/src/mesa/state_tracker/st_manager.c
> @@ -560,7 +560,7 @@ st_framebuffer_iface_remove(struct st_manager *smapi,
>(struct st_manager_private *)smapi->st_manager_private;
> struct hash_entry *entry;
>
> -   if (!smPriv || !smPriv->stfbi_ht);
> +   if (!smPriv || !smPriv->stfbi_ht)
>return;
>
> mtx_lock(>st_mutex);
> --
> 1.9.1
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] st/mesa: fix the unconditional return in st_framebuffer_iface_remove

[Charmaine Lee]

Fixes: bbc29393d3beaf6344c7188547b4ff61b63946ae
Tested-by: Christoph Haag 
---
 src/mesa/state_tracker/st_manager.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/mesa/state_tracker/st_manager.c 
b/src/mesa/state_tracker/st_manager.c
index 834bcc9..6447403 100644
--- a/src/mesa/state_tracker/st_manager.c
+++ b/src/mesa/state_tracker/st_manager.c
@@ -560,7 +560,7 @@ st_framebuffer_iface_remove(struct st_manager *smapi,
   (struct st_manager_private *)smapi->st_manager_private;
struct hash_entry *entry;
 
-   if (!smPriv || !smPriv->stfbi_ht);
+   if (!smPriv || !smPriv->stfbi_ht)
   return;
 
mtx_lock(>st_mutex);
-- 
1.9.1

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev