Re: [Mesa-dev] [PATCH] swr/rast: Optimize DumpToFile output size

2018-01-25 Thread Cherniak, Bruce
Reviewed-by: Bruce Cherniak 

> On Jan 24, 2018, at 2:50 PM, George Kyriazis  
> wrote:
> 
> Modify DumpToFile to only dump the function, not the entire module.
> Reduces file sizes and speeds up the dumping.
> ---
> src/gallium/drivers/swr/rasterizer/jitter/JitManager.cpp | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/src/gallium/drivers/swr/rasterizer/jitter/JitManager.cpp 
> b/src/gallium/drivers/swr/rasterizer/jitter/JitManager.cpp
> index 675438b..7105766 100644
> --- a/src/gallium/drivers/swr/rasterizer/jitter/JitManager.cpp
> +++ b/src/gallium/drivers/swr/rasterizer/jitter/JitManager.cpp
> @@ -421,8 +421,7 @@ void JitManager::DumpToFile(Function *f, const char 
> *fileName)
> sprintf(fName, "%s.%s.ll", funcName, fileName);
> #endif
> raw_fd_ostream fd(fName, EC, llvm::sys::fs::F_None);
> -Module* pModule = f->getParent();
> -pModule->print(fd, nullptr);
> +f->print(fd, nullptr);
> 
> #if defined(_WIN32)
> sprintf(fName, "%s\\cfg.%s.%s.dot", outDir.c_str(), funcName, 
> fileName);
> -- 
> 2.7.4
> 
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev


[Mesa-dev] [PATCH] swr/rast: Optimize DumpToFile output size

2018-01-24 Thread George Kyriazis
Modify DumpToFile to only dump the function, not the entire module.
Reduces file sizes and speeds up the dumping.
---
 src/gallium/drivers/swr/rasterizer/jitter/JitManager.cpp | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/gallium/drivers/swr/rasterizer/jitter/JitManager.cpp 
b/src/gallium/drivers/swr/rasterizer/jitter/JitManager.cpp
index 675438b..7105766 100644
--- a/src/gallium/drivers/swr/rasterizer/jitter/JitManager.cpp
+++ b/src/gallium/drivers/swr/rasterizer/jitter/JitManager.cpp
@@ -421,8 +421,7 @@ void JitManager::DumpToFile(Function *f, const char 
*fileName)
 sprintf(fName, "%s.%s.ll", funcName, fileName);
 #endif
 raw_fd_ostream fd(fName, EC, llvm::sys::fs::F_None);
-Module* pModule = f->getParent();
-pModule->print(fd, nullptr);
+f->print(fd, nullptr);
 
 #if defined(_WIN32)
 sprintf(fName, "%s\\cfg.%s.%s.dot", outDir.c_str(), funcName, 
fileName);
-- 
2.7.4

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev