Re: [Mesa-dev] [PATCH] vbo: Use alloca for _vbo_draw_indirect.

Hi, > This adds uses of alloca, without a corresponding include of alloca.h. > > Perhaps something like the attached is needed? Yes, sorry! Reviewed-by: Mathias Fröhlich best Mathias ___ mesa-dev mailing list

Re: [Mesa-dev] [PATCH] vbo: Use alloca for _vbo_draw_indirect.

On 28/03/2018 11:35, mathias.froehl...@gmx.net wrote: Avoid using malloc in the draw path of mesa. Since the draw_count is a user api input, fall back to malloc if the amount of consumed stack space may get too high. Signed-off-by: Mathias Fröhlich ---

Re: [Mesa-dev] [PATCH] vbo: Use alloca for _vbo_draw_indirect.

Hi Brian, > Can you just rename 'space' to 'prim' and rm the prim = space assignment > below? > > Also, could you put a comment on this function to explain the draw_count > and space/prim parameters, at least? I'll try my best! > Other than that, the series looks good. > > Reviewed-by: Brian

Re: [Mesa-dev] [PATCH] vbo: Use alloca for _vbo_draw_indirect.

On 03/28/2018 04:35 AM, mathias.froehl...@gmx.net wrote: From: Mathias Fröhlich Marek, you mean with the below patch as the 9-th change in the series? I would like to keep that change seprarate from #3 since patch #3 just moves the already existing impelentation to

Re: [Mesa-dev] [PATCH] vbo: Use alloca for _vbo_draw_indirect.

Yes, it looks good. Marek On Wed, Mar 28, 2018 at 6:35 AM, wrote: > From: Mathias Fröhlich > > > Marek, > > you mean with the below patch as the 9-th change in the series? > I would like to keep that change seprarate from #3 since patch #3

[Mesa-dev] [PATCH] vbo: Use alloca for _vbo_draw_indirect.

From: Mathias Fröhlich Marek, you mean with the below patch as the 9-th change in the series? I would like to keep that change seprarate from #3 since patch #3 just moves the already existing impelentation to the driver_functions level using the exactly identical