On Wed, Jul 17, 2019 at 3:59 PM Lepton Wu wrote:
>
> OK, actually struct winsys_handle is an obscure structure for virgl
> driver so we can't access whandle->stride here...
> So maybe just leave this CL as it is?
That is fair. R-b'ed and pushed.
>
> On Wed, Jul 17, 2019 at 1:12 PM Chia-I Wu
OK, actually struct winsys_handle is an obscure structure for virgl
driver so we can't access whandle->stride here...
So maybe just leave this CL as it is?
On Wed, Jul 17, 2019 at 1:12 PM Chia-I Wu wrote:
>
> On Wed, Jul 17, 2019 at 12:45 PM Lepton Wu wrote:
> > metadata->stride[0] is
On Wed, Jul 17, 2019 at 12:45 PM Lepton Wu wrote:
> metadata->stride[0] is calculated from
> util_format_get_stride(pt->format, pt->width0);
> So basically you are asking to check if
> util_format_get_stride(pt->format, pt->width0) == whandle->stride
> Should this be something done by framework?
metadata->stride[0] is calculated from
util_format_get_stride(pt->format, pt->width0);
So basically you are asking to check if
util_format_get_stride(pt->format, pt->width0) == whandle->stride
Should this be something done by framework?
On Wed, Jul 17, 2019 at 12:25 PM Chia-I Wu wrote:
>
> On
On Wed, Jul 17, 2019 at 11:44 AM Lepton Wu wrote:
>
> On Wed, Jul 17, 2019 at 11:26 AM Chia-I Wu wrote:
> >
> > On Wed, Jul 17, 2019 at 10:14 AM Erik Faye-Lund
> > wrote:
> > >
> > > On Wed, 2019-07-17 at 10:02 -0700, Lepton Wu wrote:
> > > > The set of meta data was removed by commit 8083464.
On Wed, Jul 17, 2019 at 11:26 AM Chia-I Wu wrote:
>
> On Wed, Jul 17, 2019 at 10:14 AM Erik Faye-Lund
> wrote:
> >
> > On Wed, 2019-07-17 at 10:02 -0700, Lepton Wu wrote:
> > > The set of meta data was removed by commit 8083464. It broke lots of
> > > dEQP tests when running with pbuffer surface
On Wed, Jul 17, 2019 at 10:14 AM Erik Faye-Lund
wrote:
>
> On Wed, 2019-07-17 at 10:02 -0700, Lepton Wu wrote:
> > The set of meta data was removed by commit 8083464. It broke lots of
> > dEQP tests when running with pbuffer surface type.
> >
> > Fixes: 80834640137 ("virgl: remove dead code")
> >
On Wed, 2019-07-17 at 10:02 -0700, Lepton Wu wrote:
> The set of meta data was removed by commit 8083464. It broke lots of
> dEQP tests when running with pbuffer surface type.
>
> Fixes: 80834640137 ("virgl: remove dead code")
> Signed-off-by: Lepton Wu
> ---
>
The set of meta data was removed by commit 8083464. It broke lots of
dEQP tests when running with pbuffer surface type.
Fixes: 80834640137 ("virgl: remove dead code")
Signed-off-by: Lepton Wu
---
src/gallium/drivers/virgl/virgl_resource.c | 1 +
1 file changed, 1 insertion(+)
diff --git
