Re: [Mesa-dev] [PATCH] vulkan/wsi: Improve the DRI3 error message

2017-03-01 Thread Jason Ekstrand
Pushed On Tue, Feb 28, 2017 at 8:30 PM, Jacob Lifshay wrote: > This commit improves the message by telling them that they could probably > enable DRI3. More importantly, it includes a little heuristic to check > to see if we're running on AMD or NVIDIA's proprietary

[Mesa-dev] [PATCH] vulkan/wsi: Improve the DRI3 error message

2017-02-28 Thread Jacob Lifshay
This commit improves the message by telling them that they could probably enable DRI3. More importantly, it includes a little heuristic to check to see if we're running on AMD or NVIDIA's proprietary X11 drivers and, if we are, doesn't emit the warning. This way, users with both a discrete card

Re: [Mesa-dev] [PATCH] vulkan/wsi: Improve the DRI3 error message

2017-02-26 Thread Jason Ekstrand
On Feb 25, 2017 6:17 PM, "Jacob Lifshay" wrote: Just to double check, is there anything else I need to do to have this patch committed? The only thing I've been waiting for is someone to confirm that they've tested it on a variety of configurations and that it

Re: [Mesa-dev] [PATCH] vulkan/wsi: Improve the DRI3 error message

2017-02-26 Thread Kai Wasserbäch
Not from my side. But I can't commit the patch for you. Jason? Jacob Lifshay wrote on 26.02.2017 03:17: > Just to double check, is there anything else I need to do to have this > patch committed? > Jacob Lifshay > > On Feb 19, 2017 02:08, "Kai Wasserbäch" wrote: >

Re: [Mesa-dev] [PATCH] vulkan/wsi: Improve the DRI3 error message

2017-02-25 Thread Jacob Lifshay
Just to double check, is there anything else I need to do to have this patch committed? Jacob Lifshay On Feb 19, 2017 02:08, "Kai Wasserbäch" wrote: > Jason Ekstrand wrote on 19.02.2017 06:01: > > On Feb 18, 2017 12:37 PM, "Kai Wasserbäch"

Re: [Mesa-dev] [PATCH] vulkan/wsi: Improve the DRI3 error message

2017-02-19 Thread Kai Wasserbäch
Jason Ekstrand wrote on 19.02.2017 06:01: > On Feb 18, 2017 12:37 PM, "Kai Wasserbäch" > wrote: > > Hey Jacob, > sorry for not spotting this the first time, but I have an additional > comment. > Please see below. > > Jacob Lifshay wrote on 18.02.2017 18:48:> This

Re: [Mesa-dev] [PATCH] vulkan/wsi: Improve the DRI3 error message

2017-02-18 Thread Jason Ekstrand
On Feb 18, 2017 12:37 PM, "Kai Wasserbäch" wrote: Hey Jacob, sorry for not spotting this the first time, but I have an additional comment. Please see below. Jacob Lifshay wrote on 18.02.2017 18:48:> This commit improves the message by telling them that they could

[Mesa-dev] [PATCH] vulkan/wsi: Improve the DRI3 error message

2017-02-18 Thread Jacob Lifshay
This commit improves the message by telling them that they could probably enable DRI3. More importantly, it includes a little heuristic to check to see if we're running on AMD or NVIDIA's proprietary X11 drivers and, if we are, doesn't emit the warning. This way, users with both a discrete card

Re: [Mesa-dev] [PATCH] vulkan/wsi: Improve the DRI3 error message

2017-02-18 Thread Matt Turner
On Sat, Feb 18, 2017 at 1:31 PM, Jacob Lifshay wrote: > This commit improves the message by telling them that they could probably > enable DRI3. More importantly, it includes a little heuristic to check > to see if we're running on AMD or NVIDIA's proprietary X11

[Mesa-dev] [PATCH] vulkan/wsi: Improve the DRI3 error message

2017-02-18 Thread Jacob Lifshay
This commit improves the message by telling them that they could probably enable DRI3. More importantly, it includes a little heuristic to check to see if we're running on AMD or NVIDIA's proprietary X11 drivers and, if we are, doesn't emit the warning. This way, users with both a discrete card

Re: [Mesa-dev] [PATCH] vulkan/wsi: Improve the DRI3 error message

2017-02-18 Thread Kai Wasserbäch
Hey Jacob, sorry for not spotting this the first time, but I have an additional comment. Please see below. Jacob Lifshay wrote on 18.02.2017 18:48:> This commit improves the message by telling them that they could probably > enable DRI3. More importantly, it includes a little heuristic to check

[Mesa-dev] [PATCH] vulkan/wsi: Improve the DRI3 error message

2017-02-18 Thread Jacob Lifshay
This commit improves the message by telling them that they could probably enable DRI3. More importantly, it includes a little heuristic to check to see if we're running on AMD or NVIDIA's proprietary X11 drivers and, if we are, doesn't emit the warning. This way, users with both a discrete card

Re: [Mesa-dev] [PATCH] vulkan/wsi: Improve the DRI3 error message

2017-02-18 Thread Jason Ekstrand
On Feb 18, 2017 1:59 AM, "Kai Wasserbäch" wrote: Hey Jacob, Jacob Lifshay wrote on 18.02.2017 10:40: > This commit improves the message by telling them that they could probably > enable DRI3 and giving a url to a Ask Ubuntu question showing how to do > that.

Re: [Mesa-dev] [PATCH] vulkan/wsi: Improve the DRI3 error message

2017-02-18 Thread Kai Wasserbäch
Hey Jacob, Jacob Lifshay wrote on 18.02.2017 10:40: > This commit improves the message by telling them that they could probably > enable DRI3 and giving a url to a Ask Ubuntu question showing how to do > that. wouldn't it be better to add a page to the mesa user topics section (ie. add a file to

[Mesa-dev] [PATCH] vulkan/wsi: Improve the DRI3 error message

2017-02-18 Thread Jacob Lifshay
This commit improves the message by telling them that they could probably enable DRI3 and giving a url to a Ask Ubuntu question showing how to do that. More importantly, it includes a little heuristic to check to see if we're running on AMD or NVIDIA's proprietary X11 drivers and, if we are,