Re: [Mesa-dev] [PATCH 0/2] r600: Fix array texture slice index evaluation

2018-06-26 Thread Roland Scheidegger
Am 26.06.2018 um 09:59 schrieb Gert Wollny: > Am Montag, den 25.06.2018, 23:47 +0200 schrieb Roland Scheidegger: >> >> Alright albeit you have logic to handle incoming z offsets, whereas >> that should always be 0. > I'm preparing for future standards that allow for these z-offsets ;) > >> To be

Re: [Mesa-dev] [PATCH 0/2] r600: Fix array texture slice index evaluation

2018-06-26 Thread Gert Wollny
Am Montag, den 25.06.2018, 23:47 +0200 schrieb Roland Scheidegger: > > Alright albeit you have logic to handle incoming z offsets, whereas > that should always be 0. I'm preparing for future standards that allow for these z-offsets ;) > To be honest I'm actually kind of surprised the hw would

Re: [Mesa-dev] [PATCH 0/2] r600: Fix array texture slice index evaluation

2018-06-25 Thread Roland Scheidegger
Am 25.06.2018 um 22:13 schrieb Gert Wollny: > Am Montag, den 25.06.2018, 17:36 +0200 schrieb Roland Scheidegger: >> I didn't actually get the original email for some reason, so can't >> comment inline as I'm just looking it up at patchwork... >> But the array offset stuff (the first patch) looks

Re: [Mesa-dev] [PATCH 0/2] r600: Fix array texture slice index evaluation

2018-06-25 Thread Gert Wollny
Am Montag, den 25.06.2018, 17:36 +0200 schrieb Roland Scheidegger: > I didn't actually get the original email for some reason, so can't > comment inline as I'm just looking it up at patchwork... > But the array offset stuff (the first patch) looks completely bogus > to me, array textures do not

Re: [Mesa-dev] [PATCH 0/2] r600: Fix array texture slice index evaluation

2018-06-25 Thread Roland Scheidegger
I didn't actually get the original email for some reason, so can't comment inline as I'm just looking it up at patchwork... But the array offset stuff (the first patch) looks completely bogus to me, array textures do not support offsets for the array index, at least not in any shader language I

Re: [Mesa-dev] [PATCH 0/2] r600: Fix array texture slice index evaluation

2018-06-25 Thread Dave Airlie
On 25 June 2018 at 16:24, Gert Wollny wrote: > Am Montag, den 25.06.2018, 15:54 +1000 schrieb Dave Airlie: >> /home/airlied/devel/piglit/bin/textureGather fs nonconst r 0 float >> 2DArray repeat >> >> amongst others appears to regress with these two. > > I can confirm this. From which piglit

Re: [Mesa-dev] [PATCH 0/2] r600: Fix array texture slice index evaluation

2018-06-25 Thread Gert Wollny
Am Montag, den 25.06.2018, 15:54 +1000 schrieb Dave Airlie: > /home/airlied/devel/piglit/bin/textureGather fs nonconst r 0 float > 2DArray repeat > > amongst others appears to regress with these two. I can confirm this. From which piglit subset is this? I ran the shader subset and didn't see

Re: [Mesa-dev] [PATCH 0/2] r600: Fix array texture slice index evaluation

2018-06-24 Thread Dave Airlie
/home/airlied/devel/piglit/bin/textureGather fs nonconst r 0 float 2DArray repeat amongst others appears to regress with these two. Dave. On 22 June 2018 at 19:37, Gert Wollny wrote: > these two patches correct the offets and the rounding modes for the > index evaluation when accessing

[Mesa-dev] [PATCH 0/2] r600: Fix array texture slice index evaluation

2018-06-22 Thread Gert Wollny
these two patches correct the offets and the rounding modes for the index evaluation when accessing texture arrays. The patches were tested with the gles3 test suite where they fix a number of tests related to 2D texture arrays and didn't show any regressions. Best, Gert Gert Wollny (2):