Re: [Mesa-dev] [PATCH 0/2] st/va: minor clean-ups
I've just pushed both. Thanks for the help, Christian. Am 23.08.2016 um 16:39 schrieb Kai Wasserbäch: Hey Boyuan, hey Christian, Zhang, Boyuan wrote on 22.08.2016 22:52: Thanks for cleaning up the codes. The duplicated end_frame and unused variable are due to the new patch submitted last Friday. I have reviewed both patches. thanks for your reviews! Just in case you missed my postscript in the cover letter: either of you needs to commit these changes since I do not have commit access. Thanks again, Kai -Original Message- From: Kai Wasserbäch [mailto:k...@dev.carbon-project.org] Sent: August-20-16 12:15 PM To: mesa-dev@lists.freedesktop.org Cc: Zhang, Boyuan Subject: [PATCH 0/2] st/va: minor clean-ups Hey, just noticed a duplicate call to context->decoder->end_frame() while looking through the recent changes. This is just a trivial clean-up and no functional change is intended. And while I was there, I also noticed an unused variable, which the second patch removes. Cheers, Kai P.S.: If this "series" gets accepted, please commit it for me, since I do not have commit access. Kai Wasserbäch (3): st/va: Remove else case in vlVaEndPicture() made superfluous by c59628d11b st/va: Remove unused variable coded_size from vlVaEndPicture() src/gallium/state_trackers/va/picture.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH 0/2] st/va: minor clean-ups
Hey Boyuan, hey Christian, Zhang, Boyuan wrote on 22.08.2016 22:52: > Thanks for cleaning up the codes. The duplicated end_frame and unused > variable are due to the new patch submitted last Friday. I have reviewed both > patches. thanks for your reviews! Just in case you missed my postscript in the cover letter: either of you needs to commit these changes since I do not have commit access. Thanks again, Kai > -Original Message- > From: Kai Wasserbäch [mailto:k...@dev.carbon-project.org] > Sent: August-20-16 12:15 PM > To: mesa-dev@lists.freedesktop.org > Cc: Zhang, Boyuan > Subject: [PATCH 0/2] st/va: minor clean-ups > > Hey, > just noticed a duplicate call to context->decoder->end_frame() while looking > through the recent changes. This is just a trivial clean-up and no functional > change is intended. And while I was there, I also noticed an unused variable, > which the second patch removes. > > Cheers, > Kai > > P.S.: If this "series" gets accepted, please commit it for me, since I do not > have commit access. > > > Kai Wasserbäch (3): > st/va: Remove else case in vlVaEndPicture() made superfluous by > c59628d11b > st/va: Remove unused variable coded_size from vlVaEndPicture() > > src/gallium/state_trackers/va/picture.c | 9 +++-- > 1 file changed, 3 insertions(+), 6 deletions(-) > signature.asc Description: OpenPGP digital signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH 0/2] st/va: minor clean-ups
Hi Kai, Thanks for cleaning up the codes. The duplicated end_frame and unused variable are due to the new patch submitted last Friday. I have reviewed both patches. Regards, Boyuan -Original Message- From: Kai Wasserbäch [mailto:k...@dev.carbon-project.org] Sent: August-20-16 12:15 PM To: mesa-dev@lists.freedesktop.org Cc: Zhang, Boyuan Subject: [PATCH 0/2] st/va: minor clean-ups Hey, just noticed a duplicate call to context->decoder->end_frame() while looking through the recent changes. This is just a trivial clean-up and no functional change is intended. And while I was there, I also noticed an unused variable, which the second patch removes. Cheers, Kai P.S.: If this "series" gets accepted, please commit it for me, since I do not have commit access. Kai Wasserbäch (3): st/va: Remove else case in vlVaEndPicture() made superfluous by c59628d11b st/va: Remove unused variable coded_size from vlVaEndPicture() src/gallium/state_trackers/va/picture.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) -- 2.8.1 ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH 0/2] st/va: minor clean-ups
Reviewed-by: Christian Königfor both. Regards, Christian. Am 20.08.2016 um 18:14 schrieb Kai Wasserbäch: Hey, just noticed a duplicate call to context->decoder->end_frame() while looking through the recent changes. This is just a trivial clean-up and no functional change is intended. And while I was there, I also noticed an unused variable, which the second patch removes. Cheers, Kai P.S.: If this "series" gets accepted, please commit it for me, since I do not have commit access. Kai Wasserbäch (3): st/va: Remove else case in vlVaEndPicture() made superfluous by c59628d11b st/va: Remove unused variable coded_size from vlVaEndPicture() src/gallium/state_trackers/va/picture.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [PATCH 0/2] st/va: minor clean-ups
Hey, just noticed a duplicate call to context->decoder->end_frame() while looking through the recent changes. This is just a trivial clean-up and no functional change is intended. And while I was there, I also noticed an unused variable, which the second patch removes. Cheers, Kai P.S.: If this "series" gets accepted, please commit it for me, since I do not have commit access. Kai Wasserbäch (3): st/va: Remove else case in vlVaEndPicture() made superfluous by c59628d11b st/va: Remove unused variable coded_size from vlVaEndPicture() src/gallium/state_trackers/va/picture.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) -- 2.8.1 ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev