Re: [Mesa-dev] [PATCH 0/3] Fix and tweak to the VAO v2

2018-02-05 Thread Brian Paul 

On 02/05/2018 03:19 PM, mathias.froehl...@gmx.net wrote:

From: Mathias Fröhlich 

Hi Brian,

Actually after incorporating your review requests to set
gl_vertex_array::Size and gl_vertex_array::Ptr to zero, radeonsi
started to assert in Bitmap/CopyPixels/DrawPixels.
Which assertion, exactly?  And what test triggers it?  I'd like to take 
a close look with the llvmpipe/svga drivers just so I understand what's 
happening.


-Brian



So, here the updated series including the requested changes.
And additoinally for review the change to fix the mentioned asserts
in several piglit tests.

Please review!

best

Mathias


Mathias Fröhlich (3):
   mesa: Fix VAO buffer object tracking.
   mesa: Mute arrays for Bitmap/CopyPixels/DrawPixels callbacks.
   mesa: Only update enabled VAO gl_vertex_array entries.

  src/mesa/main/drawpix.c | 10 ++
  src/mesa/main/varray.c  | 10 ++
  src/mesa/main/varray.h  | 29 ++---
  3 files changed, 34 insertions(+), 15 deletions(-)



___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 0/3] Fix and tweak to the VAO v2

2018-02-05 Thread Mathias . Froehlich 
From: Mathias Fröhlich 

Hi Brian,

Actually after incorporating your review requests to set
gl_vertex_array::Size and gl_vertex_array::Ptr to zero, radeonsi
started to assert in Bitmap/CopyPixels/DrawPixels.

So, here the updated series including the requested changes.
And additoinally for review the change to fix the mentioned asserts
in several piglit tests.

Please review!

best

Mathias


Mathias Fröhlich (3):
  mesa: Fix VAO buffer object tracking.
  mesa: Mute arrays for Bitmap/CopyPixels/DrawPixels callbacks.
  mesa: Only update enabled VAO gl_vertex_array entries.

 src/mesa/main/drawpix.c | 10 ++
 src/mesa/main/varray.c  | 10 ++
 src/mesa/main/varray.h  | 29 ++---
 3 files changed, 34 insertions(+), 15 deletions(-)

-- 
2.14.3

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev