Re: [Mesa-dev] [PATCH 0/8] anv, spirv: Implement VK_KHR_variable_pointers

[Iago Toral]

On Fri, 2017-07-14 at 10:34 -0700, Jason Ekstrand wrote:
> On Fri, Jul 14, 2017 at 3:09 AM, Iago Toral 
> wrote:
> > Patches 1-5 and 7-8 are:
> > 
> > Reviewed-by: Iago Toral Quiroga 
> > 
> > 
> > 
> > I dropped minor comments to patches 4-5, feel free to ignore them
> > if
> > 
> > you don't consider them relevant though.
> > 
> > 
> > 
> > I also dropped a couple of comments on patch 6. It looks good to me
> > in
> > 
> > general but I think this one needs someone more knowledgeable in
> > SPIRV
> > 
> > and variable pointers than me for a proper review, so you might
> > want to
> > 
> > have someone else have a look at this one.
> 
> I think you're as qualified as anyone at this point.

Thanks for the clarifications you sent, feel free to add my Rb to patch
6 as well after removing the dead loop in there.
Iago
> > Iago
> > 
> > 
> > 
> > On Thu, 2017-07-13 at 12:41 -0700, Jason Ekstrand wrote:
> > 
> > > This little series contains the SPIR-V and ANV bits for the new
> > 
> > > VK_KHR_variable_pointers extension and it's prerequisite
> > extension
> > 
> > > VK_KHR_storage_buffer_storage_class.
> > 
> > >
> > 
> > > Cc: Connor Abbott 
> > 
> > >
> > 
> > > Jason Ekstrand (8):
> > 
> > >   spirv: Import the latest 1.0.2 header from Khronos
> > 
> > >   spirv: Add support for the StorageBuffer storage class
> > 
> > >   spirv/nir: Add some useful asserts for type decorations
> > 
> > >   nir/spirv: Implement OpPtrAccessChain for buffers
> > 
> > >   nir/spirv: Add a helper for pushing SSA values
> > 
> > >   nir/spirv: Add support for SPV_KHR_variable_pointers
> > 
> > >   anv: Advertise support for VK_KHR_storage_buffer_storage_class
> > 
> > >   anv: Advertise support for VK_KHR_variable_pointers
> > 
> > >
> > 
> > >  src/compiler/spirv/nir_spirv.h  |  1 +
> > 
> > >  src/compiler/spirv/spirv.h  | 41 --
> > 
> > >  src/compiler/spirv/spirv_to_nir.c   | 53
> > ---
> > 
> > >  src/compiler/spirv/vtn_cfg.c| 16 +++
> > 
> > >  src/compiler/spirv/vtn_private.h| 39 +++--
> > 
> > >  src/compiler/spirv/vtn_variables.c  | 77
> > 
> > > ++---
> > 
> > >  src/intel/vulkan/anv_device.c   | 15 +++
> > 
> > >  src/intel/vulkan/anv_entrypoints_gen.py |  2 +
> > 
> > >  src/intel/vulkan/anv_pipeline.c |  1 +
> > 
> > >  9 files changed, 220 insertions(+), 25 deletions(-)
> > 
> > >
> > 
> > ___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 0/8] anv, spirv: Implement VK_KHR_variable_pointers

[Jason Ekstrand]

On Fri, Jul 14, 2017 at 3:09 AM, Iago Toral  wrote:

> Patches 1-5 and 7-8 are:
> Reviewed-by: Iago Toral Quiroga 
>
> I dropped minor comments to patches 4-5, feel free to ignore them if
> you don't consider them relevant though.
>
> I also dropped a couple of comments on patch 6. It looks good to me in
> general but I think this one needs someone more knowledgeable in SPIRV
> and variable pointers than me for a proper review, so you might want to
> have someone else have a look at this one.


I think you're as qualified as anyone at this point.


>
> Iago
>
> On Thu, 2017-07-13 at 12:41 -0700, Jason Ekstrand wrote:
> > This little series contains the SPIR-V and ANV bits for the new
> > VK_KHR_variable_pointers extension and it's prerequisite extension
> > VK_KHR_storage_buffer_storage_class.
> >
> > Cc: Connor Abbott 
> >
> > Jason Ekstrand (8):
> >   spirv: Import the latest 1.0.2 header from Khronos
> >   spirv: Add support for the StorageBuffer storage class
> >   spirv/nir: Add some useful asserts for type decorations
> >   nir/spirv: Implement OpPtrAccessChain for buffers
> >   nir/spirv: Add a helper for pushing SSA values
> >   nir/spirv: Add support for SPV_KHR_variable_pointers
> >   anv: Advertise support for VK_KHR_storage_buffer_storage_class
> >   anv: Advertise support for VK_KHR_variable_pointers
> >
> >  src/compiler/spirv/nir_spirv.h  |  1 +
> >  src/compiler/spirv/spirv.h  | 41 --
> >  src/compiler/spirv/spirv_to_nir.c   | 53 ---
> >  src/compiler/spirv/vtn_cfg.c| 16 +++
> >  src/compiler/spirv/vtn_private.h| 39 +++--
> >  src/compiler/spirv/vtn_variables.c  | 77
> > ++---
> >  src/intel/vulkan/anv_device.c   | 15 +++
> >  src/intel/vulkan/anv_entrypoints_gen.py |  2 +
> >  src/intel/vulkan/anv_pipeline.c |  1 +
> >  9 files changed, 220 insertions(+), 25 deletions(-)
> >
>
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 0/8] anv, spirv: Implement VK_KHR_variable_pointers

[Iago Toral]

Patches 1-5 and 7-8 are:
Reviewed-by: Iago Toral Quiroga 

I dropped minor comments to patches 4-5, feel free to ignore them if
you don't consider them relevant though.

I also dropped a couple of comments on patch 6. It looks good to me in
general but I think this one needs someone more knowledgeable in SPIRV
and variable pointers than me for a proper review, so you might want to
have someone else have a look at this one.

Iago

On Thu, 2017-07-13 at 12:41 -0700, Jason Ekstrand wrote:
> This little series contains the SPIR-V and ANV bits for the new
> VK_KHR_variable_pointers extension and it's prerequisite extension
> VK_KHR_storage_buffer_storage_class.
> 
> Cc: Connor Abbott 
> 
> Jason Ekstrand (8):
>   spirv: Import the latest 1.0.2 header from Khronos
>   spirv: Add support for the StorageBuffer storage class
>   spirv/nir: Add some useful asserts for type decorations
>   nir/spirv: Implement OpPtrAccessChain for buffers
>   nir/spirv: Add a helper for pushing SSA values
>   nir/spirv: Add support for SPV_KHR_variable_pointers
>   anv: Advertise support for VK_KHR_storage_buffer_storage_class
>   anv: Advertise support for VK_KHR_variable_pointers
> 
>  src/compiler/spirv/nir_spirv.h  |  1 +
>  src/compiler/spirv/spirv.h  | 41 --
>  src/compiler/spirv/spirv_to_nir.c   | 53 ---
>  src/compiler/spirv/vtn_cfg.c| 16 +++
>  src/compiler/spirv/vtn_private.h| 39 +++--
>  src/compiler/spirv/vtn_variables.c  | 77
> ++---
>  src/intel/vulkan/anv_device.c   | 15 +++
>  src/intel/vulkan/anv_entrypoints_gen.py |  2 +
>  src/intel/vulkan/anv_pipeline.c |  1 +
>  9 files changed, 220 insertions(+), 25 deletions(-)
> 
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 0/8] anv, spirv: Implement VK_KHR_variable_pointers

[Jason Ekstrand]

This little series contains the SPIR-V and ANV bits for the new
VK_KHR_variable_pointers extension and it's prerequisite extension
VK_KHR_storage_buffer_storage_class.

Cc: Connor Abbott 

Jason Ekstrand (8):
  spirv: Import the latest 1.0.2 header from Khronos
  spirv: Add support for the StorageBuffer storage class
  spirv/nir: Add some useful asserts for type decorations
  nir/spirv: Implement OpPtrAccessChain for buffers
  nir/spirv: Add a helper for pushing SSA values
  nir/spirv: Add support for SPV_KHR_variable_pointers
  anv: Advertise support for VK_KHR_storage_buffer_storage_class
  anv: Advertise support for VK_KHR_variable_pointers

 src/compiler/spirv/nir_spirv.h  |  1 +
 src/compiler/spirv/spirv.h  | 41 --
 src/compiler/spirv/spirv_to_nir.c   | 53 ---
 src/compiler/spirv/vtn_cfg.c| 16 +++
 src/compiler/spirv/vtn_private.h| 39 +++--
 src/compiler/spirv/vtn_variables.c  | 77 ++---
 src/intel/vulkan/anv_device.c   | 15 +++
 src/intel/vulkan/anv_entrypoints_gen.py |  2 +
 src/intel/vulkan/anv_pipeline.c |  1 +
 9 files changed, 220 insertions(+), 25 deletions(-)

-- 
2.5.0.400.gff86faf

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev