Re: [Mesa-dev] [PATCH 0/9] glsl: cleanup and fix handling of unnamed struct types

2017-06-08 Thread Nicolai Hähnle
Final ping. If I don't hear anything, I'll push this with the changes requested by Timothy at the end of the week. Cheers, Nicolai On 22.05.2017 13:31, Nicolai Hähnle wrote: Hey Ian, Do you want more time to look into this? I double-checked that glslang accepts this code pattern. Cheers,

Re: [Mesa-dev] [PATCH 0/9] glsl: cleanup and fix handling of unnamed struct types

2017-05-22 Thread Nicolai Hähnle
Hey Ian, Do you want more time to look into this? I double-checked that glslang accepts this code pattern. Cheers, Nicolai On 16.05.2017 14:29, Nicolai Hähnle wrote: On 16.05.2017 02:56, Ian Romanick wrote: On 05/15/2017 02:27 AM, Nicolai Hähnle wrote: Hi all, This series aims to

Re: [Mesa-dev] [PATCH 0/9] glsl: cleanup and fix handling of unnamed struct types

2017-05-16 Thread Nicolai Hähnle
On 16.05.2017 02:56, Ian Romanick wrote: On 05/15/2017 02:27 AM, Nicolai Hähnle wrote: Hi all, This series aims to simplify how we handle unnamed struct types and fix some bugs on the way. Some of the patches should be uncontroversial, and all of them align with my understanding of the GLSL

Re: [Mesa-dev] [PATCH 0/9] glsl: cleanup and fix handling of unnamed struct types

2017-05-15 Thread Ian Romanick
On 05/15/2017 02:27 AM, Nicolai Hähnle wrote: > Hi all, > > This series aims to simplify how we handle unnamed struct types and fix some > bugs on the way. Some of the patches should be uncontroversial, and all of > them align with my understanding of the GLSL spec, but the spec isn't > exactly

Re: [Mesa-dev] [PATCH 0/9] glsl: cleanup and fix handling of unnamed struct types

2017-05-15 Thread Nicolai Hähnle
On 15.05.2017 16:57, Erik Faye-Lund wrote: On Mon, May 15, 2017 at 11:27 AM, Nicolai Hähnle wrote: Hi all, This series aims to simplify how we handle unnamed struct types and fix some bugs on the way. Some of the patches should be uncontroversial, and all of them align

Re: [Mesa-dev] [PATCH 0/9] glsl: cleanup and fix handling of unnamed struct types

2017-05-15 Thread Erik Faye-Lund
On Mon, May 15, 2017 at 11:27 AM, Nicolai Hähnle wrote: > Hi all, > > This series aims to simplify how we handle unnamed struct types and fix some > bugs on the way. Some of the patches should be uncontroversial, and all of > them align with my understanding of the GLSL spec,

[Mesa-dev] [PATCH 0/9] glsl: cleanup and fix handling of unnamed struct types

2017-05-15 Thread Nicolai Hähnle
Hi all, This series aims to simplify how we handle unnamed struct types and fix some bugs on the way. Some of the patches should be uncontroversial, and all of them align with my understanding of the GLSL spec, but the spec isn't exactly explicit, so... At a high level, the series changes two