[Mesa-dev] [PATCH 00/17] Newbie Project : Enable ARB_map_buffer_alignment in all drivers

2013-11-24 Thread Siavash Eliasi
Hello, this is a series of patches to accomplish *Enable ARB_map_buffer_alignment in all drivers* newbie project suggested by Ian Romanick. *Note* that I don't have write access, please merge them upstream after review process. Best Regards, Siavash Eliasi. Siavash Eliasi (17): Modified

Re: [Mesa-dev] [PATCH 00/17] Newbie Project : Enable ARB_map_buffer_alignment in all drivers

2013-11-24 Thread Timothy Arceri
I've only had a very quick scan over your patches but I think you need to redo your patches that edit case statements as you are not just changing the value of the intended case statement but also all of the cases above it as they do not break or return they just fall through for example: ---

Re: [Mesa-dev] [PATCH 00/17] Newbie Project : Enable ARB_map_buffer_alignment in all drivers

2013-11-24 Thread Chris Forbes
Tim's correct -- in this case you probably want to move the PIPE_CAP_MIN_MAP_BUFFER_ALIGNMENT case up above the big 'this cap is unsupported' catch-all. -- Chris On Mon, Nov 25, 2013 at 7:07 PM, Timothy Arceri t_arc...@yahoo.com.au wrote: I've only had a very quick scan over your patches but I

Re: [Mesa-dev] [PATCH 00/17] Newbie Project : Enable ARB_map_buffer_alignment in all drivers

2013-11-24 Thread Chris Forbes
Ah, I see you have a follow-up that fixes this already. Looks good, sorry for the noise. -- Chris On Mon, Nov 25, 2013 at 8:19 PM, Chris Forbes chr...@ijw.co.nz wrote: Tim's correct -- in this case you probably want to move the PIPE_CAP_MIN_MAP_BUFFER_ALIGNMENT case up above the big 'this cap

Re: [Mesa-dev] [PATCH 00/17] Newbie Project : Enable ARB_map_buffer_alignment in all drivers

2013-11-24 Thread Siavash Eliasi
On 11/25/2013 10:50 AM, Chris Forbes wrote: Ah, I see you have a follow-up that fixes this already. Looks good, sorry for the noise. -- Chris I'm pretty new here and I'm not used to mailing lists, sorry if patches aren't showing up in correct place. Should I send all of patches again (and

Re: [Mesa-dev] [PATCH 00/17] Newbie Project : Enable ARB_map_buffer_alignment in all drivers

2013-11-24 Thread Chris Forbes
It would be good to fold the fixes into the patches they belong in. I'd wait until you collect review comments on the whole series, then incorporate all the review you get and send out a new version at that point. -- Chris On Mon, Nov 25, 2013 at 8:29 PM, Siavash Eliasi siavashser...@gmail.com