Re: [Mesa-dev] [PATCH 01/10] panfrost: Move scanout res creation out of panfrost_resource_create()

2019-07-02 Thread Tomeu Vizoso
Besides the leak, I think I preferred the open-coded version, which is incidentally what all other drivers I've seen do. The modifiers work is going to massively change this code anyway. But I'm not against it, so Reviewed-by: Tomeu Vizoso Cheers, Tomeu On Tue, 2 Jul 2019 at 15:24, Boris

[Mesa-dev] [PATCH 01/10] panfrost: Move scanout res creation out of panfrost_resource_create()

2019-07-02 Thread Boris Brezillon
Which improves readability and help us avoid a memory leak. Signed-off-by: Boris Brezillon --- src/gallium/drivers/panfrost/pan_resource.c | 79 - 1 file changed, 44 insertions(+), 35 deletions(-) diff --git a/src/gallium/drivers/panfrost/pan_resource.c