Re: [Mesa-dev] [PATCH 01/21] vulkan: Add KHR_display extension using DRM

2018-03-07 Thread Keith Packard
Daniel Stone writes: > Or better, just use drmModeAddFB2 and pass the format directly. That > landed back in 3.2 or so, and I don't think there's anyone trying to > use Vulkan on a kernel from 2011. Yeah, that's probably a better plan. I've pushed a patch that does this on

Re: [Mesa-dev] [PATCH 01/21] vulkan: Add KHR_display extension using DRM

2018-03-07 Thread Keith Packard
Jason Ekstrand writes: Thanks a million for the intense review. I've pushed 15 tiny patches that address individual questions in this message. If you want to look at those separately, that would be great. When we're done, I'll merge them back into the giant patch. Sorry

Re: [Mesa-dev] [PATCH 01/21] vulkan: Add KHR_display extension using DRM

2018-02-25 Thread Daniel Stone
Hi, On 24 February 2018 at 00:43, Jason Ekstrand wrote: > On Tue, Feb 13, 2018 at 4:31 PM, Keith Packard wrote: >> + image->chain = chain; >> + image->state = wsi_image_idle; >> + image->fb_id = 0; >> + >> + /* XXX extract depth and bpp from

Re: [Mesa-dev] [PATCH 01/21] vulkan: Add KHR_display extension using DRM

2018-02-23 Thread Jason Ekstrand
Continuing on the new version of the patch... On Tue, Feb 13, 2018 at 4:31 PM, Keith Packard wrote: > +enum wsi_image_state { > + wsi_image_idle, > + wsi_image_drawing, > + wsi_image_queued, > + wsi_image_flipping, > + wsi_image_displaying > +}; > With the

[Mesa-dev] [PATCH 01/21] vulkan: Add KHR_display extension using DRM

2018-02-13 Thread Keith Packard
This adds support for the KHR_display extension support to the vulkan WSI layer. Driver support will be added separately. Signed-off-by: Keith Packard --- configure.ac|1 + meson.build |4 +- src/amd/vulkan/radv_wsi.c