Re: [Mesa-dev] [PATCH 02/13] i965: Allow passing target_bo=NULL to brw_emit_reloc()

2017-07-20 Thread Kenneth Graunke
On Thursday, July 20, 2017 7:29:52 AM PDT Chris Wilson wrote: > Quoting Chris Wilson (2017-07-20 15:15:02) > > Quoting Kenneth Graunke (2017-07-19 21:08:23) > > > On Wednesday, July 19, 2017 3:09:10 AM PDT Chris Wilson wrote: > > > > Sometimes we want to emit a relocation to a NULL surface when

Re: [Mesa-dev] [PATCH 02/13] i965: Allow passing target_bo=NULL to brw_emit_reloc()

2017-07-20 Thread Chris Wilson
Quoting Chris Wilson (2017-07-20 15:15:02) > Quoting Kenneth Graunke (2017-07-19 21:08:23) > > On Wednesday, July 19, 2017 3:09:10 AM PDT Chris Wilson wrote: > > > Sometimes we want to emit a relocation to a NULL surface when the > > > constructing the batch. If we push the NULL handling into the

Re: [Mesa-dev] [PATCH 02/13] i965: Allow passing target_bo=NULL to brw_emit_reloc()

2017-07-20 Thread Chris Wilson
Quoting Kenneth Graunke (2017-07-19 21:08:23) > On Wednesday, July 19, 2017 3:09:10 AM PDT Chris Wilson wrote: > > Sometimes we want to emit a relocation to a NULL surface when the > > constructing the batch. If we push the NULL handling into the common > > brw_emit_reloc() we can make the batch

Re: [Mesa-dev] [PATCH 02/13] i965: Allow passing target_bo=NULL to brw_emit_reloc()

2017-07-19 Thread Kenneth Graunke
On Wednesday, July 19, 2017 3:09:10 AM PDT Chris Wilson wrote: > Sometimes we want to emit a relocation to a NULL surface when the > constructing the batch. If we push the NULL handling into the common > brw_emit_reloc() we can make the batch construction itself more > readable. I don't like

[Mesa-dev] [PATCH 02/13] i965: Allow passing target_bo=NULL to brw_emit_reloc()

2017-07-19 Thread Chris Wilson
Sometimes we want to emit a relocation to a NULL surface when the constructing the batch. If we push the NULL handling into the common brw_emit_reloc() we can make the batch construction itself more readable. On the other hand, we often test for the existence of the bo separately and so would