Re: [Mesa-dev] [PATCH 06/16] intel/icl: Do StateCacheInvalidation for indirect clear color

2018-02-13 Thread Kenneth Graunke
On Tuesday, February 13, 2018 11:15:06 AM PST Anuj Phogat wrote:
> StateCacheInvalidation is required on all gen7+ platforms. We
> don't need to update this check for every new gen h/w unless
> this requirement is changed. So, dropping the check for latest
> gen h/w.
> 
> Signed-off-by: Anuj Phogat 
> ---
>  src/intel/blorp/blorp_genX_exec.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/intel/blorp/blorp_genX_exec.h 
> b/src/intel/blorp/blorp_genX_exec.h
> index 1968460be0..7420b9d91a 100644
> --- a/src/intel/blorp/blorp_genX_exec.h
> +++ b/src/intel/blorp/blorp_genX_exec.h
> @@ -1389,7 +1389,7 @@ blorp_emit_surface_states(struct blorp_batch *batch,
>}
> }
>  
> -#if GEN_GEN >= 7 && GEN_GEN <= 10
> +#if GEN_GEN >= 7
> if (has_indirect_clear_color) {
>/* Updating a surface state object may require that the state cache be
> * invalidated. From the SKL PRM, Shared Functions -> State -> State
> 

Reviewed-by: Kenneth Graunke 


signature.asc
Description: This is a digitally signed message part.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev


[Mesa-dev] [PATCH 06/16] intel/icl: Do StateCacheInvalidation for indirect clear color

2018-02-13 Thread Anuj Phogat
StateCacheInvalidation is required on all gen7+ platforms. We
don't need to update this check for every new gen h/w unless
this requirement is changed. So, dropping the check for latest
gen h/w.

Signed-off-by: Anuj Phogat 
---
 src/intel/blorp/blorp_genX_exec.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/intel/blorp/blorp_genX_exec.h 
b/src/intel/blorp/blorp_genX_exec.h
index 1968460be0..7420b9d91a 100644
--- a/src/intel/blorp/blorp_genX_exec.h
+++ b/src/intel/blorp/blorp_genX_exec.h
@@ -1389,7 +1389,7 @@ blorp_emit_surface_states(struct blorp_batch *batch,
   }
}
 
-#if GEN_GEN >= 7 && GEN_GEN <= 10
+#if GEN_GEN >= 7
if (has_indirect_clear_color) {
   /* Updating a surface state object may require that the state cache be
* invalidated. From the SKL PRM, Shared Functions -> State -> State
-- 
2.13.6

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev