Re: [Mesa-dev] [PATCH 08/15] glsl: Switch ast_type_qualifier to a 128-bit bitset.

Not my area of expertise, but sure. Reviewed-by: Roland Scheidegger Am 27.02.2018 um 20:14 schrieb Francisco Jerez: > Do you care enough to give me a reviewed-by so I could land it right > away? > > Roland Scheidegger writes: > >> Please don't wait any

Re: [Mesa-dev] [PATCH 08/15] glsl: Switch ast_type_qualifier to a 128-bit bitset.

Do you care enough to give me a reviewed-by so I could land it right away? Roland Scheidegger writes: > Please don't wait any longer. We really want appveyor (and some of our > own build systems) going again... > > Roland > > Am 27.02.2018 um 19:58 schrieb Francisco Jerez:

Re: [Mesa-dev] [PATCH 08/15] glsl: Switch ast_type_qualifier to a 128-bit bitset.

Please don't wait any longer. We really want appveyor (and some of our own build systems) going again... Roland Am 27.02.2018 um 19:58 schrieb Francisco Jerez: > Thanks for testing. I'm going to land the build fix with your > Tested-by's if nobody raises any concerns in the next 24h. > >

Re: [Mesa-dev] [PATCH 08/15] glsl: Switch ast_type_qualifier to a 128-bit bitset.

Thanks for testing. I'm going to land the build fix with your Tested-by's if nobody raises any concerns in the next 24h. "Kyriazis, George" writes: > It also fixes the errors that I was getting with gcc 5.4.0 with configure > build on ubuntu 16.04. > > Tested-By:

Re: [Mesa-dev] [PATCH 08/15] glsl: Switch ast_type_qualifier to a 128-bit bitset.

It also fixes the errors that I was getting with gcc 5.4.0 with configure build on ubuntu 16.04. Tested-By: George Kyriazis > On Feb 25, 2018, at 6:52 PM, Roland Scheidegger > wrote: Am

Re: [Mesa-dev] [PATCH 08/15] glsl: Switch ast_type_qualifier to a 128-bit bitset.

Hi, On 25.02.2018 22:12, Francisco Jerez wrote: Roland Scheidegger writes: Am 25.02.2018 um 03:35 schrieb Francisco Jerez: Roland Scheidegger writes: This seems to have broken compilation with some gcc versions (with scons build): In file included

Re: [Mesa-dev] [PATCH 08/15] glsl: Switch ast_type_qualifier to a 128-bit bitset.

Am 25.02.2018 um 21:12 schrieb Francisco Jerez: > Roland Scheidegger writes: > >> Am 25.02.2018 um 03:35 schrieb Francisco Jerez: >>> Roland Scheidegger writes: >>> This seems to have broken compilation with some gcc versions (with scons build):

Re: [Mesa-dev] [PATCH 08/15] glsl: Switch ast_type_qualifier to a 128-bit bitset.

Roland Scheidegger writes: > Am 25.02.2018 um 03:35 schrieb Francisco Jerez: >> Roland Scheidegger writes: >> >>> This seems to have broken compilation with some gcc versions (with scons >>> build): >>> >>> In file included from

Re: [Mesa-dev] [PATCH 08/15] glsl: Switch ast_type_qualifier to a 128-bit bitset.

This seems to have broken compilation with some gcc versions (with scons build): In file included from src/compiler/glsl/ast_array_index.cpp:24:0: src/compiler/glsl/ast.h:648:16: error: member ‘ast_type_qualifier::bitset_t ast_type_qualifier::flags::i’ with constructor not allowed in union

Re: [Mesa-dev] [PATCH 08/15] glsl: Switch ast_type_qualifier to a 128-bit bitset.

Am 25.02.2018 um 03:35 schrieb Francisco Jerez: > Roland Scheidegger writes: > >> This seems to have broken compilation with some gcc versions (with scons >> build): >> >> In file included from src/compiler/glsl/ast_array_index.cpp:24:0: >> src/compiler/glsl/ast.h:648:16:

Re: [Mesa-dev] [PATCH 08/15] glsl: Switch ast_type_qualifier to a 128-bit bitset.

Roland Scheidegger writes: > This seems to have broken compilation with some gcc versions (with scons > build): > > In file included from src/compiler/glsl/ast_array_index.cpp:24:0: > src/compiler/glsl/ast.h:648:16: error: member > ‘ast_type_qualifier::bitset_t

[Mesa-dev] [PATCH 08/15] glsl: Switch ast_type_qualifier to a 128-bit bitset.

This should end the drought of bits in the ast_type_qualifier object. The bitset_t type works pretty much as a drop-in replacement for the current uint64_t bitset. The only catch is that the bitset_t type as defined in the previous commit doesn't have a trivial constructor (because it has a