I merged these, but I accidentally pulled the wrong versions. If anyone ever
wonders why some of the review comment wasn't addressed, it was I just applied
v1 instead of v2 :/
Dylan
Quoting Dylan Baker (2018-07-11 10:13:55)
> I've sent 4-9 to our CI, and assuming that it comes back green I'll go
I've sent 4-9 to our CI, and assuming that it comes back green I'll go ahead and
merge those patches today.
Quoting Mathieu Bridon (2018-07-05 06:17:40)
> Python 2 has a range() function which returns a list, and an xrange()
> one which returns an iterator.
>
> Python 3 lost the function
This patch is
Reviewed-by: Ian Romanick
On 07/06/2018 03:22 AM, Mathieu Bridon wrote:
> Python 2 has a range() function which returns a list, and an xrange()
> one which returns an iterator.
>
> Python 3 lost the function returning a list, and renamed the function
> returning an iterator as
Python 2 has a range() function which returns a list, and an xrange()
one which returns an iterator.
Python 3 lost the function returning a list, and renamed the function
returning an iterator as range().
As a result, using range() makes the scripts compatible with both Python
versions 2 and 3.
This has the same python 2 performance issue, so I'd like to either drop python2
support at the end, or do something to make python2 performance not terrible.
but, with Eric's comments addressed,
Reviewed-by: Dylan Baker
Quoting Mathieu Bridon (2018-07-05 06:17:40)
> Python 2 has a range()
On Thursday, 2018-07-05 15:17:40 +0200, Mathieu Bridon wrote:
> Python 2 has a range() function which returns a list, and an xrange()
> one which returns an iterator.
>
> Python 3 lost the function returning a list, and renamed the function
> returning an iterator as range().
>
> As a result,
Python 2 has a range() function which returns a list, and an xrange()
one which returns an iterator.
Python 3 lost the function returning a list, and renamed the function
returning an iterator as range().
As a result, using range() makes the scripts compatible with both Python
versions 2 and 3.
