Re: [Mesa-dev] [PATCH 1/1] gallivm: Fix build after llvm r328839

[Jan Vesely]

On Fri, 2018-03-30 at 18:41 +0200, Dieter Nützel wrote:
> Hello Jan,
> 
> can you have a look on this one (instead) and commit?
> https://lists.freedesktop.org/archives/mesa-dev/2018-March/190535.html
> https://patchwork.freedesktop.org/series/40916/

You should probably ask respective maintainers for that.
Looking at the patch, it'd be nicer if split. I didn't notice that
ac/nir prefixed change touches gallivm. It'd also be preferrable if
LLVM reference used revision numbers instead of git hash (afaik llvm
still uses mainly svn).

Jan

> 
> It has r-b from Samuel Pitoiset and t-b from me.
> 
> Thanks,
> 
> Dieter
> 
> Am 30.03.2018 18:30, schrieb Jan Vesely:
> > LLVM r328839 moved few function declrations to a new Utils.h header.
> > Fixes:
> > gallivm/lp_bld_init.c:145:7: error: implicit declaration of function
> > ‘LLVMAddPromoteMemoryToRegisterPass’; did you mean
> > ‘LLVMAddDemoteMemoryToRegisterPass’?
> > 
> > Signed-off-by: Jan Vesely 
> > ---
> >  src/gallium/auxiliary/gallivm/lp_bld_init.c | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/src/gallium/auxiliary/gallivm/lp_bld_init.c
> > b/src/gallium/auxiliary/gallivm/lp_bld_init.c
> > index 6ddc509a81..dae9d01552 100644
> > --- a/src/gallium/auxiliary/gallivm/lp_bld_init.c
> > +++ b/src/gallium/auxiliary/gallivm/lp_bld_init.c
> > @@ -40,6 +40,9 @@
> > 
> >  #include 
> >  #include 
> > +#if HAVE_LLVM >= 0x0700
> > +#include 
> > +#endif
> >  #include 


signature.asc
Description: This is a digitally signed message part
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 1/1] gallivm: Fix build after llvm r328839

[Dieter Nützel]

Hello Jan,

can you have a look on this one (instead) and commit?
https://lists.freedesktop.org/archives/mesa-dev/2018-March/190535.html
https://patchwork.freedesktop.org/series/40916/

It has r-b from Samuel Pitoiset and t-b from me.

Thanks,

Dieter

Am 30.03.2018 18:30, schrieb Jan Vesely:

LLVM r328839 moved few function declrations to a new Utils.h header.
Fixes:
gallivm/lp_bld_init.c:145:7: error: implicit declaration of function
‘LLVMAddPromoteMemoryToRegisterPass’; did you mean
‘LLVMAddDemoteMemoryToRegisterPass’?

Signed-off-by: Jan Vesely 
---
 src/gallium/auxiliary/gallivm/lp_bld_init.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/gallium/auxiliary/gallivm/lp_bld_init.c
b/src/gallium/auxiliary/gallivm/lp_bld_init.c
index 6ddc509a81..dae9d01552 100644
--- a/src/gallium/auxiliary/gallivm/lp_bld_init.c
+++ b/src/gallium/auxiliary/gallivm/lp_bld_init.c
@@ -40,6 +40,9 @@

 #include 
 #include 
+#if HAVE_LLVM >= 0x0700
+#include 
+#endif
 #include 

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 1/1] gallivm: Fix build after llvm r328839

[Jan Vesely]

LLVM r328839 moved few function declrations to a new Utils.h header.
Fixes:
gallivm/lp_bld_init.c:145:7: error: implicit declaration of function 
‘LLVMAddPromoteMemoryToRegisterPass’; did you mean 
‘LLVMAddDemoteMemoryToRegisterPass’?

Signed-off-by: Jan Vesely 
---
 src/gallium/auxiliary/gallivm/lp_bld_init.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/gallium/auxiliary/gallivm/lp_bld_init.c 
b/src/gallium/auxiliary/gallivm/lp_bld_init.c
index 6ddc509a81..dae9d01552 100644
--- a/src/gallium/auxiliary/gallivm/lp_bld_init.c
+++ b/src/gallium/auxiliary/gallivm/lp_bld_init.c
@@ -40,6 +40,9 @@
 
 #include 
 #include 
+#if HAVE_LLVM >= 0x0700
+#include 
+#endif
 #include 
 
 
-- 
2.14.3

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev