Re: [Mesa-dev] [PATCH 1/2] compiler/nir: add a is_image_sample_dref flag to texture instructions

2018-04-02 Thread Iago Toral
On Wed, 2018-03-28 at 17:19 -0700, Jason Ekstrand wrote: > How is this different from is_shadow? From the SPIR-V spec, OpTypeImage: "Depth is whether or not this image is a depth image. (Note that whether or not depth comparisons are actually done is a property of the sampling opcode, not

Re: [Mesa-dev] [PATCH 1/2] compiler/nir: add a is_image_sample_dref flag to texture instructions

2018-03-28 Thread Jason Ekstrand
How is this different from is_shadow? On March 28, 2018 02:33:50 Iago Toral Quiroga wrote: So we can recognize image sampling instructions that involve a depth comparison against a reference, such as SPIR-V's OpImageSample{Proj}Dref{Explicit,Implicit}Lod and we can

[Mesa-dev] [PATCH 1/2] compiler/nir: add a is_image_sample_dref flag to texture instructions

2018-03-28 Thread Iago Toral Quiroga
So we can recognize image sampling instructions that involve a depth comparison against a reference, such as SPIR-V's OpImageSample{Proj}Dref{Explicit,Implicit}Lod and we can acknowledge that they return a single scalar value instead of a vec4. --- src/compiler/nir/nir.h | 9 +