Re: [Mesa-dev] [PATCH 1/2] travis: add ubuntu-toolchain-r-test

2018-08-07 Thread Emil Velikov
On 7 August 2018 at 18:06, Juan A. Suarez Romero  wrote:
> On Tue, 2018-08-07 at 12:57 -0400, Jan Vesely wrote:
>>
>>
>> On Tue, Aug 7, 2018 at 12:28 PM, Juan A. Suarez Romero  
>> wrote:
>> > On Tue, 2018-08-07 at 16:12 +0100, Emil Velikov wrote:
>> > > On 6 August 2018 at 11:17, Juan A. Suarez Romero  
>> > > wrote:
>> > > > LLVM 6.0 requires GCC 4.9, which is not available in main Travis
>> > > > repository.
>> > > >
>> > >
>> > > We're not building LLVM 6.0 here, hence the commit message is a bit 
>> > > confusing.
>> > > Please add more information on the topic - even a bug report if there is 
>> > > one.
>> > >
>> >
>> > We are using now LLVM 6.0, for "make Vulkan" and "make Gallium Drivers
>> > RadeonSI".
>> >
>> > Previously we were using LLVM 6.0 for "make Gallium ST Clover LLVM-6.0", 
>> > which
>> > already had this ubuntu-toolchain-r-test.
>> >
>> > Without this, we get an error like in
>> > https://travis-ci.org/mesa3d/mesa/jobs/413159413
>>
>> I think Emil's point was that we actually need libstc++4.9, because llvm-lib 
>> link to it, rather than the gcc compiler itself.
>>
>
> Ah, I see. I'll update the commit message to say that libstdc++4.9 is 
> required,
> instead of GCC 4.9.
>
> Emil: with this change, is this R-b from you?
>
Of course. Pardon for the initial "not using LLVM 6.0" goof-up.

Thanks
Emi
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev


Re: [Mesa-dev] [PATCH 1/2] travis: add ubuntu-toolchain-r-test

2018-08-07 Thread Juan A. Suarez Romero
On Tue, 2018-08-07 at 12:57 -0400, Jan Vesely wrote:
> 
> 
> On Tue, Aug 7, 2018 at 12:28 PM, Juan A. Suarez Romero  
> wrote:
> > On Tue, 2018-08-07 at 16:12 +0100, Emil Velikov wrote:
> > > On 6 August 2018 at 11:17, Juan A. Suarez Romero  
> > > wrote:
> > > > LLVM 6.0 requires GCC 4.9, which is not available in main Travis
> > > > repository.
> > > > 
> > > 
> > > We're not building LLVM 6.0 here, hence the commit message is a bit 
> > > confusing.
> > > Please add more information on the topic - even a bug report if there is 
> > > one.
> > > 
> > 
> > We are using now LLVM 6.0, for "make Vulkan" and "make Gallium Drivers
> > RadeonSI".
> > 
> > Previously we were using LLVM 6.0 for "make Gallium ST Clover LLVM-6.0", 
> > which
> > already had this ubuntu-toolchain-r-test.
> > 
> > Without this, we get an error like in 
> > https://travis-ci.org/mesa3d/mesa/jobs/413159413
> 
> I think Emil's point was that we actually need libstc++4.9, because llvm-lib 
> link to it, rather than the gcc compiler itself.
> 

Ah, I see. I'll update the commit message to say that libstdc++4.9 is required,
instead of GCC 4.9.

Emil: with this change, is this R-b from you?

J.A.

> Jan
>  
> > 
> > 
> > 
> > J.A.
> > 
> > > With that
> > > Reviewed-by: Emil Velikov 
> > > 
> > > -Emil
> > > 
> > 
> > ___
> > mesa-dev mailing list
> > mesa-dev@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/mesa-dev
> 
> 

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev


Re: [Mesa-dev] [PATCH 1/2] travis: add ubuntu-toolchain-r-test

2018-08-07 Thread Andres Gomez
With a bit more clarifying commit log, this is:

Reviewed-by: Andres Gomez 

On Mon, 2018-08-06 at 12:17 +0200, Juan A. Suarez Romero wrote:
> LLVM 6.0 requires GCC 4.9, which is not available in main Travis
> repository.
> 
> Fixes: fd1121e8399 ("amd: remove support for LLVM 5.0")
> CC: Marek Olšák 
> ---
>  .travis.yml | 4 
>  1 file changed, 4 insertions(+)
> 
> diff --git a/.travis.yml b/.travis.yml
> index fb192ae82a2..f7c2a8da996 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -137,6 +137,8 @@ matrix:
>  apt:
>sources:
>  - llvm-toolchain-trusty-6.0
> +# llvm-6 depends on gcc-4.9 which is not in main repo
> +- ubuntu-toolchain-r-test
>packages:
>  # LLVM packaging is broken and misses these dependencies
>  - libedit-dev
> @@ -378,6 +380,8 @@ matrix:
>  apt:
>sources:
>  - llvm-toolchain-trusty-6.0
> +# llvm-6 depends on gcc-4.9 which is not in main repo
> +- ubuntu-toolchain-r-test
>packages:
>  # LLVM packaging is broken and misses these dependencies
>  - libedit-dev
-- 
Br,

Andres
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev


Re: [Mesa-dev] [PATCH 1/2] travis: add ubuntu-toolchain-r-test

2018-08-07 Thread Jan Vesely
On Tue, Aug 7, 2018 at 12:28 PM, Juan A. Suarez Romero 
wrote:

> On Tue, 2018-08-07 at 16:12 +0100, Emil Velikov wrote:
> > On 6 August 2018 at 11:17, Juan A. Suarez Romero 
> wrote:
> > > LLVM 6.0 requires GCC 4.9, which is not available in main Travis
> > > repository.
> > >
> >
> > We're not building LLVM 6.0 here, hence the commit message is a bit
> confusing.
> > Please add more information on the topic - even a bug report if there is
> one.
> >
>
> We are using now LLVM 6.0, for "make Vulkan" and "make Gallium Drivers
> RadeonSI".
>
> Previously we were using LLVM 6.0 for "make Gallium ST Clover LLVM-6.0",
> which
> already had this ubuntu-toolchain-r-test.
>
> Without this, we get an error like in
> https://travis-ci.org/mesa3d/mesa/jobs/413159413


I think Emil's point was that we actually need libstc++4.9, because
llvm-lib link to it, rather than the gcc compiler itself.

Jan


>
>
>
>
> J.A.
>
> > With that
> > Reviewed-by: Emil Velikov 
> >
> > -Emil
> >
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev


Re: [Mesa-dev] [PATCH 1/2] travis: add ubuntu-toolchain-r-test

2018-08-07 Thread Juan A. Suarez Romero
On Tue, 2018-08-07 at 16:12 +0100, Emil Velikov wrote:
> On 6 August 2018 at 11:17, Juan A. Suarez Romero  wrote:
> > LLVM 6.0 requires GCC 4.9, which is not available in main Travis
> > repository.
> > 
> 
> We're not building LLVM 6.0 here, hence the commit message is a bit confusing.
> Please add more information on the topic - even a bug report if there is one.
> 

We are using now LLVM 6.0, for "make Vulkan" and "make Gallium Drivers
RadeonSI".

Previously we were using LLVM 6.0 for "make Gallium ST Clover LLVM-6.0", which
already had this ubuntu-toolchain-r-test.

Without this, we get an error like in 
https://travis-ci.org/mesa3d/mesa/jobs/413159413



J.A.

> With that
> Reviewed-by: Emil Velikov 
> 
> -Emil
> 

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev


Re: [Mesa-dev] [PATCH 1/2] travis: add ubuntu-toolchain-r-test

2018-08-07 Thread Emil Velikov
On 6 August 2018 at 11:17, Juan A. Suarez Romero  wrote:
> LLVM 6.0 requires GCC 4.9, which is not available in main Travis
> repository.
>

We're not building LLVM 6.0 here, hence the commit message is a bit confusing.
Please add more information on the topic - even a bug report if there is one.

With that
Reviewed-by: Emil Velikov 

-Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev


Re: [Mesa-dev] [PATCH 1/2] travis: add ubuntu-toolchain-r-test

2018-08-06 Thread Juan A. Suarez Romero
On Mon, 2018-08-06 at 12:17 +0200, Juan A. Suarez Romero wrote:
> LLVM 6.0 requires GCC 4.9, which is not available in main Travis
> repository.
> 
> Fixes: fd1121e8399 ("amd: remove support for LLVM 5.0")
> CC: Marek Olšák 

Cc: Emil Velikov 
Cc: Dylan Baker 


> 
> ---
>  .travis.yml | 4 
>  1 file changed, 4 insertions(+)
> 
> diff --git a/.travis.yml b/.travis.yml
> index fb192ae82a2..f7c2a8da996 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -137,6 +137,8 @@ matrix:
>  apt:
>sources:
>  - llvm-toolchain-trusty-6.0
> +# llvm-6 depends on gcc-4.9 which is not in main repo
> +- ubuntu-toolchain-r-test
>packages:
>  # LLVM packaging is broken and misses these dependencies
>  - libedit-dev
> @@ -378,6 +380,8 @@ matrix:
>  apt:
>sources:
>  - llvm-toolchain-trusty-6.0
> +# llvm-6 depends on gcc-4.9 which is not in main repo
> +- ubuntu-toolchain-r-test
>packages:
>  # LLVM packaging is broken and misses these dependencies
>  - libedit-dev

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev


[Mesa-dev] [PATCH 1/2] travis: add ubuntu-toolchain-r-test

2018-08-06 Thread Juan A. Suarez Romero
LLVM 6.0 requires GCC 4.9, which is not available in main Travis
repository.

Fixes: fd1121e8399 ("amd: remove support for LLVM 5.0")
CC: Marek Olšák 
---
 .travis.yml | 4 
 1 file changed, 4 insertions(+)

diff --git a/.travis.yml b/.travis.yml
index fb192ae82a2..f7c2a8da996 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -137,6 +137,8 @@ matrix:
 apt:
   sources:
 - llvm-toolchain-trusty-6.0
+# llvm-6 depends on gcc-4.9 which is not in main repo
+- ubuntu-toolchain-r-test
   packages:
 # LLVM packaging is broken and misses these dependencies
 - libedit-dev
@@ -378,6 +380,8 @@ matrix:
 apt:
   sources:
 - llvm-toolchain-trusty-6.0
+# llvm-6 depends on gcc-4.9 which is not in main repo
+- ubuntu-toolchain-r-test
   packages:
 # LLVM packaging is broken and misses these dependencies
 - libedit-dev
-- 
2.17.1

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev