Re: [Mesa-dev] [PATCH 1/3] glsl: XFB TSC per-vertex output varyings match as not declared as arrays

2019-02-22 Thread Chema Casanova
V2 of this series that address the fix for KHR-GL*.tessellation_shader.single.xfb_captures_data_from_correct_stage regressions is available at Gitlab MR!300 https://gitlab.freedesktop.org/mesa/mesa/merge_requests/300 On 21/11/18 19:45, Jose Maria Casanova Crespo wrote: > Recent change on OpenGL

Re: [Mesa-dev] [PATCH 1/3] glsl: XFB TSC per-vertex output varyings match as not declared as arrays

2019-02-04 Thread Ilia Mirkin
IMHO this is done at the wrong level. You're effectively keeping track of a per-variable "this variable belongs to a tcs output that's not a patch" bit. Doesn't seem worthy of a whole separate bit. Also, you use ->without_array() a lot, but what you really need to do is remove *one* layer of

Re: [Mesa-dev] [PATCH 1/3] glsl: XFB TSC per-vertex output varyings match as not declared as arrays

2018-12-13 Thread Chema Casanova
Ping. El 22/11/18 a las 0:28, Chema Casanova escribió: > > > On 21/11/18 20:04, Ilia Mirkin wrote: >> On Wed, Nov 21, 2018 at 1:45 PM Jose Maria Casanova Crespo >> wrote: >>> >>> Recent change on OpenGL CTS ("Use non-arrayed varying name for TCS blocks") >>> on

Re: [Mesa-dev] [PATCH 1/3] glsl: XFB TSC per-vertex output varyings match as not declared as arrays

2018-11-21 Thread Chema Casanova
On 21/11/18 20:04, Ilia Mirkin wrote: > On Wed, Nov 21, 2018 at 1:45 PM Jose Maria Casanova Crespo > wrote: >> >> Recent change on OpenGL CTS ("Use non-arrayed varying name for TCS blocks") >> on KHR-GL*.tessellation_shader.single.xfb_captures_data_from_correct_stage >> tests changed how to

Re: [Mesa-dev] [PATCH 1/3] glsl: XFB TSC per-vertex output varyings match as not declared as arrays

2018-11-21 Thread Ilia Mirkin
On Wed, Nov 21, 2018 at 1:45 PM Jose Maria Casanova Crespo wrote: > > Recent change on OpenGL CTS ("Use non-arrayed varying name for TCS blocks") > on KHR-GL*.tessellation_shader.single.xfb_captures_data_from_correct_stage > tests changed how to name per-vertex Tessellation Control Shader output

[Mesa-dev] [PATCH 1/3] glsl: XFB TSC per-vertex output varyings match as not declared as arrays

2018-11-21 Thread Jose Maria Casanova Crespo
Recent change on OpenGL CTS ("Use non-arrayed varying name for TCS blocks") on KHR-GL*.tessellation_shader.single.xfb_captures_data_from_correct_stage tests changed how to name per-vertex Tessellation Control Shader output varyings in transform feedback using interface block as "BLOCK_INOUT.value"