On Fri, 15 Feb 2019 at 21:42, Alyssa Rosenzweig wrote:
>
> > Nit: staying consistent with "foo != NULL" vs "foo" checks helps a
> > lot.
>
> Which form is preferred?
>
I think that varies across parts of mesa. I'd pick one and use it
through panfrost.
> > free(NULL); is perfectly valid.
>
> Huh,
> Nit: staying consistent with "foo != NULL" vs "foo" checks helps a
> lot.
Which form is preferred?
> free(NULL); is perfectly valid.
Huh, TIL, thank you.
> The function pointer seems to be NULL. Did you forget to git add the
> file which sets it?
See my comment in the other mail about the
Hi Alyssa,
On Fri, 15 Feb 2019 at 08:50, Alyssa Rosenzweig wrote:
>
> Signed-off-by: Alyssa Rosenzweig
> ---
> src/gallium/drivers/panfrost/pan_resource.c | 22 -
> src/gallium/drivers/panfrost/pan_screen.h | 4 +++-
> 2 files changed, 16 insertions(+), 10 deletions(-)
>
Signed-off-by: Alyssa Rosenzweig
---
src/gallium/drivers/panfrost/pan_resource.c | 22 -
src/gallium/drivers/panfrost/pan_screen.h | 4 +++-
2 files changed, 16 insertions(+), 10 deletions(-)
diff --git a/src/gallium/drivers/panfrost/pan_resource.c
