Re: [Mesa-dev] [PATCH 1/4] nir/split_var_copies: handle IMAGE and SAMPLER for bindless vars

2018-04-04 Thread Jason Ekstrand
On Wed, Apr 4, 2018 at 3:33 AM, Timothy Arceri wrote: > On 04/04/18 20:20, Karol Herbst wrote: > >> On Wed, Apr 4, 2018 at 2:23 AM, Jason Ekstrand >> wrote: >> >>> I have a very strong feeling that this isn't the only place where >>> reading/writing IMAGE and SAMPLER variables is going to cause

Re: [Mesa-dev] [PATCH 1/4] nir/split_var_copies: handle IMAGE and SAMPLER for bindless vars

2018-04-04 Thread Timothy Arceri
On 04/04/18 20:20, Karol Herbst wrote: On Wed, Apr 4, 2018 at 2:23 AM, Jason Ekstrand wrote: I have a very strong feeling that this isn't the only place where reading/writing IMAGE and SAMPLER variables is going to cause NIR heartburn. For example, we have special cases in nir_validate for SUBR

Re: [Mesa-dev] [PATCH 1/4] nir/split_var_copies: handle IMAGE and SAMPLER for bindless vars

2018-04-04 Thread Karol Herbst
On Wed, Apr 4, 2018 at 2:23 AM, Jason Ekstrand wrote: > I have a very strong feeling that this isn't the only place where > reading/writing IMAGE and SAMPLER variables is going to cause NIR heartburn. > For example, we have special cases in nir_validate for SUBROUTINE variables > and we probably n

Re: [Mesa-dev] [PATCH 1/4] nir/split_var_copies: handle IMAGE and SAMPLER for bindless vars

2018-04-03 Thread Jason Ekstrand
I have a very strong feeling that this isn't the only place where reading/writing IMAGE and SAMPLER variables is going to cause NIR heartburn. For example, we have special cases in nir_validate for SUBROUTINE variables and we probably need IMAGE and SAMPLER support everywhere we have SUBROUTINE pl

[Mesa-dev] [PATCH 1/4] nir/split_var_copies: handle IMAGE and SAMPLER for bindless vars

2018-04-03 Thread Karol Herbst
Signed-off-by: Karol Herbst --- src/compiler/nir/nir_split_var_copies.c | 4 1 file changed, 4 insertions(+) diff --git a/src/compiler/nir/nir_split_var_copies.c b/src/compiler/nir/nir_split_var_copies.c index bc3ceedbdb8..231a89add4d 100644 --- a/src/compiler/nir/nir_split_var_copies.c ++