Re: [Mesa-dev] [PATCH 1/5] ac/nir: fix nir_op_b2i16

[Bas Nieuwenhuizen]

r-b for the series.

On Tue, Mar 26, 2019 at 11:31 AM Samuel Pitoiset
 wrote:
>
> Signed-off-by: Samuel Pitoiset 
> ---
>  src/amd/common/ac_nir_to_llvm.c | 12 +---
>  1 file changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c
> index 2321fed69f3..d74693ddd68 100644
> --- a/src/amd/common/ac_nir_to_llvm.c
> +++ b/src/amd/common/ac_nir_to_llvm.c
> @@ -344,10 +344,16 @@ static LLVMValueRef emit_b2i(struct ac_llvm_context 
> *ctx,
>  {
> LLVMValueRef result = LLVMBuildAnd(ctx->builder, src0, ctx->i32_1, 
> "");
>
> -   if (bitsize == 32)
> +   switch (bitsize) {
> +   case 16:
> +   return LLVMBuildTrunc(ctx->builder, result, ctx->i16, "");
> +   case 32:
> return result;
> -
> -   return LLVMBuildZExt(ctx->builder, result, ctx->i64, "");
> +   case 64:
> +   return LLVMBuildZExt(ctx->builder, result, ctx->i64, "");
> +   default:
> +   unreachable("Unsupported bit size.");
> +   }
>  }
>
>  static LLVMValueRef emit_i2b(struct ac_llvm_context *ctx,
> --
> 2.21.0
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 1/5] ac/nir: fix nir_op_b2i16

[Samuel Pitoiset]

Signed-off-by: Samuel Pitoiset 
---
 src/amd/common/ac_nir_to_llvm.c | 12 +---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c
index 2321fed69f3..d74693ddd68 100644
--- a/src/amd/common/ac_nir_to_llvm.c
+++ b/src/amd/common/ac_nir_to_llvm.c
@@ -344,10 +344,16 @@ static LLVMValueRef emit_b2i(struct ac_llvm_context *ctx,
 {
LLVMValueRef result = LLVMBuildAnd(ctx->builder, src0, ctx->i32_1, "");
 
-   if (bitsize == 32)
+   switch (bitsize) {
+   case 16:
+   return LLVMBuildTrunc(ctx->builder, result, ctx->i16, "");
+   case 32:
return result;
-
-   return LLVMBuildZExt(ctx->builder, result, ctx->i64, "");
+   case 64:
+   return LLVMBuildZExt(ctx->builder, result, ctx->i64, "");
+   default:
+   unreachable("Unsupported bit size.");
+   }
 }
 
 static LLVMValueRef emit_i2b(struct ac_llvm_context *ctx,
-- 
2.21.0

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev