Re: [Mesa-dev] [PATCH 1/6] i965: Add negative_equals methods

2018-03-23 Thread Ian Romanick
On 03/23/2018 12:17 PM, Chema Casanova wrote: > > > On 23/03/18 19:27, Matt Turner wrote: >> On Wed, Mar 21, 2018 at 5:58 PM, Ian Romanick wrote: >>> From: Ian Romanick >>> >>> This method is similar to the existing ::equals methods. Instead of

Re: [Mesa-dev] [PATCH 1/6] i965: Add negative_equals methods

2018-03-23 Thread Chema Casanova
On 23/03/18 19:27, Matt Turner wrote: > On Wed, Mar 21, 2018 at 5:58 PM, Ian Romanick wrote: >> From: Ian Romanick >> >> This method is similar to the existing ::equals methods. Instead of >> testing that two src_regs are equal to each other, it

Re: [Mesa-dev] [PATCH 1/6] i965: Add negative_equals methods

2018-03-23 Thread Matt Turner
On Wed, Mar 21, 2018 at 5:58 PM, Ian Romanick wrote: > From: Ian Romanick > > This method is similar to the existing ::equals methods. Instead of > testing that two src_regs are equal to each other, it tests that one is > the negation of the

Re: [Mesa-dev] [PATCH 1/6] i965: Add negative_equals methods

2018-03-23 Thread Alejandro Piñeiro
On 23/03/18 16:13, Ian Romanick wrote: > On 03/23/2018 01:21 AM, Alejandro Piñeiro wrote: >> On 22/03/18 19:08, Ian Romanick wrote: >>> On 03/22/2018 01:12 AM, Alejandro Piñeiro wrote: Looks good in general, just a comment below. On 22/03/18 01:58, Ian Romanick wrote: >

Re: [Mesa-dev] [PATCH 1/6] i965: Add negative_equals methods

2018-03-23 Thread Ian Romanick
On 03/23/2018 01:21 AM, Alejandro Piñeiro wrote: > On 22/03/18 19:08, Ian Romanick wrote: >> On 03/22/2018 01:12 AM, Alejandro Piñeiro wrote: >>> Looks good in general, just a comment below. >>> >>> >>> On 22/03/18 01:58, Ian Romanick wrote: From: Ian Romanick

Re: [Mesa-dev] [PATCH 1/6] i965: Add negative_equals methods

2018-03-23 Thread Alejandro Piñeiro
On 22/03/18 19:08, Ian Romanick wrote: > On 03/22/2018 01:12 AM, Alejandro Piñeiro wrote: >> Looks good in general, just a comment below. >> >> >> On 22/03/18 01:58, Ian Romanick wrote: >>> From: Ian Romanick >>> >>> This method is similar to the existing ::equals

Re: [Mesa-dev] [PATCH 1/6] i965: Add negative_equals methods

2018-03-22 Thread Ian Romanick
On 03/22/2018 01:12 AM, Alejandro Piñeiro wrote: > Looks good in general, just a comment below. > > > On 22/03/18 01:58, Ian Romanick wrote: >> From: Ian Romanick >> >> This method is similar to the existing ::equals methods. Instead of >> testing that two src_regs

Re: [Mesa-dev] [PATCH 1/6] i965: Add negative_equals methods

2018-03-22 Thread Alejandro Piñeiro
Looks good in general, just a comment below. On 22/03/18 01:58, Ian Romanick wrote: > From: Ian Romanick > > This method is similar to the existing ::equals methods. Instead of > testing that two src_regs are equal to each other, it tests that one is > the negation of

[Mesa-dev] [PATCH 1/6] i965: Add negative_equals methods

2018-03-21 Thread Ian Romanick
From: Ian Romanick This method is similar to the existing ::equals methods. Instead of testing that two src_regs are equal to each other, it tests that one is the negation of the other. v2: Simplify various checks based on suggestions from Matt. Use src_reg::type