Re: [Mesa-dev] [PATCH 1/7] intel/isl: Add bounds-checking assertions in isl_format_get_layout

2018-06-07 Thread Lionel Landwerlin
You left out isl_buffer_fill_image_param() in isl_storage_image.c Regardless, this is an improvement and with this I actually hit the assert :) Reviewed-by: Lionel Landwerlin On 06/06/18 18:47, Jason Ekstrand wrote: We add two assertions instead of one because the first assertion that

[Mesa-dev] [PATCH 1/7] intel/isl: Add bounds-checking assertions in isl_format_get_layout

2018-06-06 Thread Jason Ekstrand
We add two assertions instead of one because the first assertion that format != ISL_FORMAT_UNSUPPORTED is more descriptive and checks for a real but unsupported enumerant while the second ensures that they don't pass in garbage values. We also update some other helpers to use