Re: [Mesa-dev] [PATCH 1/7] mesa: Add types for ARB_transform_feedback_oveflow_query.

[Kenneth Graunke]

On Wednesday, December 7, 2016 10:50:29 AM PST Rafael Antognolli wrote:
> Add some basic types and storage for the queries of this extension.
> 
> Signed-off-by: Rafael Antognolli 
> ---
>  src/mesa/main/extensions_table.h | 1 +
>  src/mesa/main/mtypes.h   | 5 +
>  2 files changed, 6 insertions(+)
> 
> diff --git a/src/mesa/main/extensions_table.h 
> b/src/mesa/main/extensions_table.h
> index 9c3b776..18a7097 100644
> --- a/src/mesa/main/extensions_table.h
> +++ b/src/mesa/main/extensions_table.h
> @@ -161,6 +161,7 @@ EXT(ARB_timer_query , 
> ARB_timer_query
>  EXT(ARB_transform_feedback2 , ARB_transform_feedback2
> , GLL, GLC,  x ,  x , 2010)
>  EXT(ARB_transform_feedback3 , ARB_transform_feedback3
> , GLL, GLC,  x ,  x , 2010)
>  EXT(ARB_transform_feedback_instanced, 
> ARB_transform_feedback_instanced   , GLL, GLC,  x ,  x , 2011)
> +EXT(ARB_transform_feedback_overflow_query   , 
> ARB_transform_feedback_overflow_query  , GLL, GLC,  x ,  x , 2016)

This should be 2014 (the date the spec was first written).

It's unlikely to matter though - this is for the MESA_EXTENSION_MAX_YEAR
hack which allows users to stop exposing extensions past a certain year,
which is rarely used.  (It's to work around old buggy GL apps that used
a fixed size buffer for the extension string, so exposing too many
extensions would trigger the buffer overflow in their game.)

>  EXT(ARB_transpose_matrix, dummy_true 
> , GLL,  x ,  x ,  x , 1999)
>  EXT(ARB_uniform_buffer_object   , ARB_uniform_buffer_object  
> , GLL, GLC,  x ,  x , 2009)
>  EXT(ARB_vertex_array_bgra   , EXT_vertex_array_bgra  
> , GLL, GLC,  x ,  x , 2008)
> diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h
> index 71bd89e..19956ab 100644
> --- a/src/mesa/main/mtypes.h
> +++ b/src/mesa/main/mtypes.h
> @@ -3003,6 +3003,10 @@ struct gl_query_state
> struct gl_query_object *PrimitivesGenerated[MAX_VERTEX_STREAMS];
> struct gl_query_object *PrimitivesWritten[MAX_VERTEX_STREAMS];
>  
> +   /** GL_ARB_transform_feedback_overflow_query */
> +   struct gl_query_object *TransformFeedbackOverflow[MAX_VERTEX_STREAMS];
> +   struct gl_query_object *TransformFeedbackOverflowAny;
> +
> /** GL_ARB_timer_query */
> struct gl_query_object *TimeElapsed;
>  
> @@ -3873,6 +3877,7 @@ struct gl_extensions
> GLboolean ARB_transform_feedback2;
> GLboolean ARB_transform_feedback3;
> GLboolean ARB_transform_feedback_instanced;
> +   GLboolean ARB_transform_feedback_overflow_query;
> GLboolean ARB_uniform_buffer_object;
> GLboolean ARB_vertex_attrib_64bit;
> GLboolean ARB_vertex_program;
> 



signature.asc
Description: This is a digitally signed message part.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 1/7] mesa: Add types for ARB_transform_feedback_oveflow_query.

[Rafael Antognolli]

Add some basic types and storage for the queries of this extension.

Signed-off-by: Rafael Antognolli 
---
 src/mesa/main/extensions_table.h | 1 +
 src/mesa/main/mtypes.h   | 5 +
 2 files changed, 6 insertions(+)

diff --git a/src/mesa/main/extensions_table.h b/src/mesa/main/extensions_table.h
index 9c3b776..18a7097 100644
--- a/src/mesa/main/extensions_table.h
+++ b/src/mesa/main/extensions_table.h
@@ -161,6 +161,7 @@ EXT(ARB_timer_query , 
ARB_timer_query
 EXT(ARB_transform_feedback2 , ARB_transform_feedback2  
  , GLL, GLC,  x ,  x , 2010)
 EXT(ARB_transform_feedback3 , ARB_transform_feedback3  
  , GLL, GLC,  x ,  x , 2010)
 EXT(ARB_transform_feedback_instanced, ARB_transform_feedback_instanced 
  , GLL, GLC,  x ,  x , 2011)
+EXT(ARB_transform_feedback_overflow_query   , 
ARB_transform_feedback_overflow_query  , GLL, GLC,  x ,  x , 2016)
 EXT(ARB_transpose_matrix, dummy_true   
  , GLL,  x ,  x ,  x , 1999)
 EXT(ARB_uniform_buffer_object   , ARB_uniform_buffer_object
  , GLL, GLC,  x ,  x , 2009)
 EXT(ARB_vertex_array_bgra   , EXT_vertex_array_bgra
  , GLL, GLC,  x ,  x , 2008)
diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h
index 71bd89e..19956ab 100644
--- a/src/mesa/main/mtypes.h
+++ b/src/mesa/main/mtypes.h
@@ -3003,6 +3003,10 @@ struct gl_query_state
struct gl_query_object *PrimitivesGenerated[MAX_VERTEX_STREAMS];
struct gl_query_object *PrimitivesWritten[MAX_VERTEX_STREAMS];
 
+   /** GL_ARB_transform_feedback_overflow_query */
+   struct gl_query_object *TransformFeedbackOverflow[MAX_VERTEX_STREAMS];
+   struct gl_query_object *TransformFeedbackOverflowAny;
+
/** GL_ARB_timer_query */
struct gl_query_object *TimeElapsed;
 
@@ -3873,6 +3877,7 @@ struct gl_extensions
GLboolean ARB_transform_feedback2;
GLboolean ARB_transform_feedback3;
GLboolean ARB_transform_feedback_instanced;
+   GLboolean ARB_transform_feedback_overflow_query;
GLboolean ARB_uniform_buffer_object;
GLboolean ARB_vertex_attrib_64bit;
GLboolean ARB_vertex_program;
-- 
2.7.4

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev