Re: [Mesa-dev] [PATCH 1/9] mesa: Handle common extension checks with more compact code

On Fri, May 19, 2017 at 04:29:16PM -0700, Ian Romanick wrote: > On 05/19/2017 10:28 AM, Nanley Chery wrote: > > On Fri, May 19, 2017 at 06:38:03AM -0700, Ian Romanick wrote: > >> From: Ian Romanick > >> > >> The previous code handled everything with the general case. I

Re: [Mesa-dev] [PATCH 1/9] mesa: Handle common extension checks with more compact code

On Fri, May 19, 2017 at 05:32:07PM -0700, Ian Romanick wrote: > On 05/19/2017 05:07 PM, Ilia Mirkin wrote: > > On Fri, May 19, 2017 at 7:29 PM, Ian Romanick wrote: > >> I missed that glsl_parser_extras.cpp has its own implementation of the > >> has_XXX_foo() functions that

Re: [Mesa-dev] [PATCH 1/9] mesa: Handle common extension checks with more compact code

On 05/19/2017 05:07 PM, Ilia Mirkin wrote: > On Fri, May 19, 2017 at 7:29 PM, Ian Romanick wrote: >> I missed that glsl_parser_extras.cpp has its own implementation of the >> has_XXX_foo() functions that take the API and version as explicit >> parameters. Your patch

Re: [Mesa-dev] [PATCH 1/9] mesa: Handle common extension checks with more compact code

On Fri, May 19, 2017 at 7:29 PM, Ian Romanick wrote: > I missed that glsl_parser_extras.cpp has its own implementation of the > has_XXX_foo() functions that take the API and version as explicit > parameters. Your patch predates that change. There's room for some > modest

Re: [Mesa-dev] [PATCH 1/9] mesa: Handle common extension checks with more compact code

On 05/19/2017 10:28 AM, Nanley Chery wrote: > On Fri, May 19, 2017 at 06:38:03AM -0700, Ian Romanick wrote: >> From: Ian Romanick >> >> The previous code handled everything with the general case. I noticed >> that every time I converted an open-coded check to use a >>

Re: [Mesa-dev] [PATCH 1/9] mesa: Handle common extension checks with more compact code

On Fri, May 19, 2017 at 1:28 PM, Nanley Chery wrote: > The only thing I think may need > addressing is endianness. FYI, I'm happy to provide BE support, both reviewing code and testing. ___ mesa-dev mailing list

Re: [Mesa-dev] [PATCH 1/9] mesa: Handle common extension checks with more compact code

On Fri, May 19, 2017 at 06:38:03AM -0700, Ian Romanick wrote: > From: Ian Romanick > > The previous code handled everything with the general case. I noticed > that every time I converted an open-coded check to use a > _mesa_has_EXT_foo() function, the text size of the

[Mesa-dev] [PATCH 1/9] mesa: Handle common extension checks with more compact code

From: Ian Romanick The previous code handled everything with the general case. I noticed that every time I converted an open-coded check to use a _mesa_has_EXT_foo() function, the text size of the driver increased. Almost all extensions only care what the current