Re: [Mesa-dev] [PATCH 10/13] mesa, glsl, nir: reduce gl_state_index size to 2 bytes

2018-02-09 Thread Marek Olšák
On Fri, Feb 9, 2018 at 3:01 AM, Brian Paul wrote: > Again, I can't research this right now, but what values in the > gl_state_index array are greater than 255? Perhaps you can add a comment > about that. And if that's not the case, gl_state_index8? I don't remember

Re: [Mesa-dev] [PATCH 10/13] mesa, glsl, nir: reduce gl_state_index size to 2 bytes

2018-02-08 Thread Brian Paul
Again, I can't research this right now, but what values in the gl_state_index array are greater than 255? Perhaps you can add a comment about that. And if that's not the case, gl_state_index8? Also, longer term, it might be cleaner in general if the gl_state_index array was encapsulated in a

[Mesa-dev] [PATCH 10/13] mesa, glsl, nir: reduce gl_state_index size to 2 bytes

2018-02-08 Thread Marek Olšák
From: Marek Olšák Let's use the new gl_state_index16 type everywhere and remove the typecasts. This helps reduce the size of gl_program_parameter. --- src/compiler/glsl/ir.h | 2 +- src/compiler/glsl/serialize.cpp| 2 +-