Re: [Mesa-dev] [PATCH 10/14] meson: handle LLVM 'x.x.xgit-revision' versions

Please add a comment that svn suffixes are stripped by meson as of 0.43, and git suffixes are strippped as of 0.44. With that, Reviewed-by: Dylan Baker Quoting Greg V (2017-12-31 08:55:24) > When LLVM is built inside of a git repo (even way below, e.g. /usr/ports/.git >

Re: [Mesa-dev] [PATCH 10/14] meson: handle LLVM 'x.x.xgit-revision' versions

Quoting Juan A. Suarez Romero (2018-01-05 04:42:05) > On Fri, 2018-01-05 at 10:35 +0100, Gert Wollny wrote: > > On Sun, 2017-12-31 at 19:55 +0300, Greg V wrote: > > > > When LLVM is built inside of a git repo (even way below, e.g. > > > > /usr/ports/.git > > > > exists, and LLVM is built in

Re: [Mesa-dev] [PATCH 10/14] meson: handle LLVM 'x.x.xgit-revision' versions

On Fri, 2018-01-05 at 10:35 +0100, Gert Wollny wrote: > On Sun, 2017-12-31 at 19:55 +0300, Greg V wrote: > > > When LLVM is built inside of a git repo (even way below, e.g. > > > /usr/ports/.git > > > exists, and LLVM is built in /usr/ports/devel/llvm50/work), its version > > > becomes something

Re: [Mesa-dev] [PATCH 10/14] meson: handle LLVM 'x.x.xgit-revision' versions

On Sun, 2017-12-31 at 19:55 +0300, Greg V wrote: >> When LLVM is built inside of a git repo (even way below, e.g. /usr/ports/.git >> exists, and LLVM is built in /usr/ports/devel/llvm50/work), its version >> becomes something like 5.0.0git-f8ab206b2176. >> >> Don't blow up on these versions. >>

Re: [Mesa-dev] [PATCH 10/14] meson: handle LLVM 'x.x.xgit-revision' versions

Reviewed-by: Juan A. Suarez On Sun, 2017-12-31 at 19:55 +0300, Greg V wrote: > When LLVM is built inside of a git repo (even way below, e.g. /usr/ports/.git > exists, and LLVM is built in /usr/ports/devel/llvm50/work), its version > becomes something like

[Mesa-dev] [PATCH 10/14] meson: handle LLVM 'x.x.xgit-revision' versions

When LLVM is built inside of a git repo (even way below, e.g. /usr/ports/.git exists, and LLVM is built in /usr/ports/devel/llvm50/work), its version becomes something like 5.0.0git-f8ab206b2176. Don't blow up on these versions. --- meson.build | 3 +++ 1 file changed, 3 insertions(+) diff