Re: [Mesa-dev] [PATCH 13/14] egl: Track EGL_KHR_debug state when going through EGL API calls (v3)

2016-10-05 Thread Adam Jackson
On Fri, 2016-09-16 at 18:33 +0100, Emil Velikov wrote: > But regardless, this and v2 14/14 look a lot better and are > > Reviewed-by: Emil Velikov Merged, thanks. - ajax ___ mesa-dev mailing list

Re: [Mesa-dev] [PATCH 13/14] egl: Track EGL_KHR_debug state when going through EGL API calls (v3)

2016-09-16 Thread Emil Velikov
On 14 September 2016 at 14:59, Adam Jackson wrote: > From: Kyle Brenneman > > This decorates every EGL entrypoint with _EGL_FUNC_START, which records > the function name and primary dispatch object label in the current > thread state. It also adds debug

Re: [Mesa-dev] [PATCH 13/14] egl: Track EGL_KHR_debug state when going through EGL API calls (v3)

2016-09-14 Thread Kyle Brenneman
This looks right to me. -Kyle On 09/14/2016 07:59 AM, Adam Jackson wrote: From: Kyle Brenneman This decorates every EGL entrypoint with _EGL_FUNC_START, which records the function name and primary dispatch object label in the current thread state. It also adds debug

Re: [Mesa-dev] [PATCH 13/14] egl: Track EGL_KHR_debug state when going through EGL API calls

2016-09-14 Thread Kyle Brenneman
Note that the primary object can still be meaningful even on a function that's defined to never throw an error. Those functions could still send a WARN or INFO level message if they had reason to, just not a CRITICAL or ERROR level. Until any of those are added to Mesa, though, it's an

Re: [Mesa-dev] [PATCH 13/14] egl: Track EGL_KHR_debug state when going through EGL API calls

2016-09-14 Thread Emil Velikov
On 14 September 2016 at 15:00, Adam Jackson wrote: > On Wed, 2016-09-14 at 12:08 +0100, Emil Velikov wrote: > >> Thanks for reminding me - eglQueryAPI should never throw an error, >> indeed. Since EGL_KHR_debug is applicable for functions_do_ throw an >> error, one should leave

Re: [Mesa-dev] [PATCH 13/14] egl: Track EGL_KHR_debug state when going through EGL API calls

2016-09-14 Thread Adam Jackson
On Wed, 2016-09-14 at 12:08 +0100, Emil Velikov wrote: > Thanks for reminding me - eglQueryAPI should never throw an error, > indeed. Since EGL_KHR_debug is applicable for functions_do_ throw an > error, one should leave the API out of the spec text shouldn't they ? I mean, sure, but this patch

[Mesa-dev] [PATCH 13/14] egl: Track EGL_KHR_debug state when going through EGL API calls (v3)

2016-09-14 Thread Adam Jackson
From: Kyle Brenneman This decorates every EGL entrypoint with _EGL_FUNC_START, which records the function name and primary dispatch object label in the current thread state. It also adds debug report functions and calls them when appropriate. This would be useful enough

Re: [Mesa-dev] [PATCH 13/14] egl: Track EGL_KHR_debug state when going through EGL API calls

2016-09-14 Thread Emil Velikov
On 13 September 2016 at 17:46, Adam Jackson wrote: > On Tue, 2016-09-13 at 16:54 +0100, Emil Velikov wrote: >> Going through table 13.2 and the below there are some discrepancies. >> >> AFAICT some of those can be seen as spec bugs (B), while others seem >> to be missing (M) >>

Re: [Mesa-dev] [PATCH 13/14] egl: Track EGL_KHR_debug state when going through EGL API calls (v2)

2016-09-13 Thread Kyle Brenneman
On 09/13/2016 02:42 PM, Adam Jackson wrote: On Tue, 2016-09-13 at 14:14 -0600, Kyle Brenneman wrote: On 09/13/2016 11:57 AM, Adam Jackson wrote: @@ -37,7 +39,7 @@ /* This should be kept in sync with _eglInitThreadInfo() */ #define _EGL_THREAD_INFO_INITIALIZER \ - { EGL_SUCCESS,

Re: [Mesa-dev] [PATCH 13/14] egl: Track EGL_KHR_debug state when going through EGL API calls (v2)

2016-09-13 Thread Adam Jackson
On Tue, 2016-09-13 at 14:14 -0600, Kyle Brenneman wrote: > On 09/13/2016 11:57 AM, Adam Jackson wrote: > > @@ -37,7 +39,7 @@ > >    > >   /* This should be kept in sync with _eglInitThreadInfo() */ > >   #define _EGL_THREAD_INFO_INITIALIZER \ > > -   { EGL_SUCCESS, NULL, 0, NULL, NULL, NULL } > >

Re: [Mesa-dev] [PATCH 13/14] egl: Track EGL_KHR_debug state when going through EGL API calls (v2)

2016-09-13 Thread Kyle Brenneman
On 09/13/2016 11:57 AM, Adam Jackson wrote: From: Kyle Brenneman This decorates every EGL entrypoint with _EGL_FUNC_START, which records the function name and primary dispatch object label in the current thread state. It also adds debug report functions and calls them

[Mesa-dev] [PATCH 13/14] egl: Track EGL_KHR_debug state when going through EGL API calls (v2)

2016-09-13 Thread Adam Jackson
From: Kyle Brenneman This decorates every EGL entrypoint with _EGL_FUNC_START, which records the function name and primary dispatch object label in the current thread state. It also adds debug report functions and calls them when appropriate. This would be useful enough

Re: [Mesa-dev] [PATCH 13/14] egl: Track EGL_KHR_debug state when going through EGL API calls

2016-09-13 Thread Adam Jackson
On Tue, 2016-09-13 at 16:54 +0100, Emil Velikov wrote: > Going through table 13.2 and the below there are some discrepancies. > > AFAICT some of those can be seen as spec bugs (B), while others seem > to be missing (M) >  - thread - eglBindAPI (M) Not really missing, but tricky. _EGL_FUNC_START

Re: [Mesa-dev] [PATCH 13/14] egl: Track EGL_KHR_debug state when going through EGL API calls

2016-09-13 Thread Emil Velikov
On 12 September 2016 at 23:19, Adam Jackson wrote: > +static EGLBoolean > +_eglSetFuncName(const char *funcName, _EGLDisplay *disp, EGLenum objectType, > _EGLResource *object) > +{ > + if (disp != NULL) { > +thr->CurrentObjectLabel = disp->Label; > +

[Mesa-dev] [PATCH 13/14] egl: Track EGL_KHR_debug state when going through EGL API calls

2016-09-12 Thread Adam Jackson
From: Kyle Brenneman This decorates every EGL entrypoint with _EGL_FUNC_START, which records the function name and primary dispatch object label in the current thread state. It also adds debug report functions and calls them when appropriate. This would be useful enough