Re: [Mesa-dev] [PATCH 15/15] ac/nir: fix saturate emission

[Bas Nieuwenhuizen]

This patch is

Reviewed-by: Bas Nieuwenhuizen 

On Tue, Aug 8, 2017 at 3:45 AM, Connor Abbott  wrote:
> From: Connor Abbott 
>
> The .f32 was already getting added by emit_intrin_2f_param(). Noticed
> when enabling LLVM module verification.
> ---
>  src/amd/common/ac_nir_to_llvm.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c
> index bafe4d3..46e15c9 100644
> --- a/src/amd/common/ac_nir_to_llvm.c
> +++ b/src/amd/common/ac_nir_to_llvm.c
> @@ -5337,8 +5337,8 @@ static LLVMValueRef
>  emit_float_saturate(struct ac_llvm_context *ctx, LLVMValueRef v, float lo, 
> float hi)
>  {
> v = ac_to_float(ctx, v);
> -   v = emit_intrin_2f_param(ctx, "llvm.maxnum.f32", ctx->f32, v, 
> LLVMConstReal(ctx->f32, lo));
> -   return emit_intrin_2f_param(ctx, "llvm.minnum.f32", ctx->f32, v, 
> LLVMConstReal(ctx->f32, hi));
> +   v = emit_intrin_2f_param(ctx, "llvm.maxnum", ctx->f32, v, 
> LLVMConstReal(ctx->f32, lo));
> +   return emit_intrin_2f_param(ctx, "llvm.minnum", ctx->f32, v, 
> LLVMConstReal(ctx->f32, hi));
>  }
>
>
> --
> 2.9.4
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 15/15] ac/nir: fix saturate emission

[Connor Abbott]

From: Connor Abbott 

The .f32 was already getting added by emit_intrin_2f_param(). Noticed
when enabling LLVM module verification.
---
 src/amd/common/ac_nir_to_llvm.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c
index bafe4d3..46e15c9 100644
--- a/src/amd/common/ac_nir_to_llvm.c
+++ b/src/amd/common/ac_nir_to_llvm.c
@@ -5337,8 +5337,8 @@ static LLVMValueRef
 emit_float_saturate(struct ac_llvm_context *ctx, LLVMValueRef v, float lo, 
float hi)
 {
v = ac_to_float(ctx, v);
-   v = emit_intrin_2f_param(ctx, "llvm.maxnum.f32", ctx->f32, v, 
LLVMConstReal(ctx->f32, lo));
-   return emit_intrin_2f_param(ctx, "llvm.minnum.f32", ctx->f32, v, 
LLVMConstReal(ctx->f32, hi));
+   v = emit_intrin_2f_param(ctx, "llvm.maxnum", ctx->f32, v, 
LLVMConstReal(ctx->f32, lo));
+   return emit_intrin_2f_param(ctx, "llvm.minnum", ctx->f32, v, 
LLVMConstReal(ctx->f32, hi));
 }
 
 
-- 
2.9.4

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev