Re: [Mesa-dev] [PATCH 2/2] amd/addrlib: update Mesa's copy of addrlib

2018-11-21 Thread Nicolai Hähnle
On 20.11.18 07:46, Marek Olšák wrote: On Tue, Nov 20, 2018 at 12:08 AM Dave Airlie > wrote: On Tue, 20 Nov 2018 at 14:42, Marek Olšák mailto:mar...@gmail.com>> wrote: > > On Mon, Nov 19, 2018 at 7:15 PM Bas Nieuwenhuizen

Re: [Mesa-dev] [PATCH 2/2] amd/addrlib: update Mesa's copy of addrlib

2018-11-20 Thread Marek Olšák
Those are all good points. I would suggest putting the commit explanations into the code instead of commit messages, keeping the commit messages empty. When we have a good commit message, we can just copy it into the code as a comment. It's understandable that people don't understand some of my

Re: [Mesa-dev] [PATCH 2/2] amd/addrlib: update Mesa's copy of addrlib

2018-11-20 Thread Timothy Arceri
On 20/11/18 5:46 pm, Marek Olšák wrote: On Tue, Nov 20, 2018 at 12:08 AM Dave Airlie > wrote: On Tue, 20 Nov 2018 at 14:42, Marek Olšák mailto:mar...@gmail.com>> wrote: > > On Mon, Nov 19, 2018 at 7:15 PM Bas Nieuwenhuizen

Re: [Mesa-dev] [PATCH 2/2] amd/addrlib: update Mesa's copy of addrlib

2018-11-20 Thread Bas Nieuwenhuizen
wow, I apologize for wording this in a way that looks like an attack :( What I'm primarily concerned with is that this logic is effectively second-guessing addrlib, which breaks when we second-guess the wrong value for pre-existing addrlib (as was the case with the Raven issue), or when addrlib

Re: [Mesa-dev] [PATCH 2/2] amd/addrlib: update Mesa's copy of addrlib

2018-11-19 Thread Marek Olšák
On Tue, Nov 20, 2018 at 12:08 AM Dave Airlie wrote: > On Tue, 20 Nov 2018 at 14:42, Marek Olšák wrote: > > > > On Mon, Nov 19, 2018 at 7:15 PM Bas Nieuwenhuizen < > b...@basnieuwenhuizen.nl> wrote: > >> > >> So I tried to test this with radv and got a bunch of crashes in CTS, > >> mostly around

Re: [Mesa-dev] [PATCH 2/2] amd/addrlib: update Mesa's copy of addrlib

2018-11-19 Thread Marek Olšák
On Tue, Nov 20, 2018 at 12:08 AM Dave Airlie wrote: > On Tue, 20 Nov 2018 at 14:42, Marek Olšák wrote: > > > > On Mon, Nov 19, 2018 at 7:15 PM Bas Nieuwenhuizen < > b...@basnieuwenhuizen.nl> wrote: > >> > >> So I tried to test this with radv and got a bunch of crashes in CTS, > >> mostly around

Re: [Mesa-dev] [PATCH 2/2] amd/addrlib: update Mesa's copy of addrlib

2018-11-19 Thread Dave Airlie
On Tue, 20 Nov 2018 at 14:42, Marek Olšák wrote: > > On Mon, Nov 19, 2018 at 7:15 PM Bas Nieuwenhuizen > wrote: >> >> So I tried to test this with radv and got a bunch of crashes in CTS, >> mostly around 3d image support: >> >> #3 0x771a9396 in __assert_fail () from /usr/lib/libc.so.6

Re: [Mesa-dev] [PATCH 2/2] amd/addrlib: update Mesa's copy of addrlib

2018-11-19 Thread Marek Olšák
On Mon, Nov 19, 2018 at 7:15 PM Bas Nieuwenhuizen wrote: > So I tried to test this with radv and got a bunch of crashes in CTS, > mostly around 3d image support: > > #3 0x771a9396 in __assert_fail () from /usr/lib/libc.so.6 > #4 0x769da3b4 in >

Re: [Mesa-dev] [PATCH 2/2] amd/addrlib: update Mesa's copy of addrlib

2018-11-19 Thread Bas Nieuwenhuizen
So I tried to test this with radv and got a bunch of crashes in CTS, mostly around 3d image support: #3 0x771a9396 in __assert_fail () from /usr/lib/libc.so.6 #4 0x769da3b4 in Addr::V2::Gfx9Lib::HwlGetPreferredSurfaceSetting (this=0x57661b30, pIn=0x7fffd5f0,