Re: [Mesa-dev] [PATCH 2/2] egl: Add dma_buf_import_modifiers for glvnd

[Daniel Stone]

Hi Emil,

On 19 August 2017 at 00:57, Emil Velikov  wrote:
> On 11 August 2017 at 11:18, Daniel Stone  wrote:
>> On 31 July 2017 at 15:15, Daniel Stone  wrote:
>>> Make sure we advertise the new entrypoints to libglvnd's EGL dispatch.
>>
>> Anyone?
>>
> I might be too tired but I think things should work fine even without the 
> patch.
> Regardless, the commit should not cause any issues.
>
> Can you please drop the bugzilla tag - the issue seems to be different.

Emmanuel's comments #2 and #4 show that he went from
QueryDmaBufFormatsEXT not being returned by GetProcAddress (the jump
to NULL) before the patch, to those entrypoints being exposed after
it.

You're right that there's definitely a different issue at play, but
this is at least one step in fixing that ...

Cheers,
Daniel
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 2/2] egl: Add dma_buf_import_modifiers for glvnd

[Emil Velikov]

On 11 August 2017 at 11:18, Daniel Stone  wrote:
> On 31 July 2017 at 15:15, Daniel Stone  wrote:
>> Make sure we advertise the new entrypoints to libglvnd's EGL dispatch.
>
> Anyone?
>
I might be too tired but I think things should work fine even without the patch.
Regardless, the commit should not cause any issues.

Can you please drop the bugzilla tag - the issue seems to be different.

Thanks
Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 2/2] egl: Add dma_buf_import_modifiers for glvnd

[Eric Anholt]

Daniel Stone  writes:

> On 31 July 2017 at 15:15, Daniel Stone  wrote:
>> Make sure we advertise the new entrypoints to libglvnd's EGL dispatch.
>
> Anyone?

Reviewed-by: Eric Anholt 


signature.asc
Description: PGP signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 2/2] egl: Add dma_buf_import_modifiers for glvnd

[Daniel Stone]

On 31 July 2017 at 15:15, Daniel Stone  wrote:
> Make sure we advertise the new entrypoints to libglvnd's EGL dispatch.

Anyone?

Cheers,
Daniel
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 2/2] egl: Add dma_buf_import_modifiers for glvnd

[Daniel Stone]

Make sure we advertise the new entrypoints to libglvnd's EGL dispatch.

Signed-off-by: Daniel Stone 
Reported-by: Emmanuel Gil Peyrot 
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101982
Fixes: 4c412293d0e ("egl: advertise EGL_EXT_image_dma_buf_import_modifiers")
---
 src/egl/generate/eglFunctionList.py | 4 
 1 file changed, 4 insertions(+)

diff --git a/src/egl/generate/eglFunctionList.py 
b/src/egl/generate/eglFunctionList.py
index 80cb83437c..fb5b3c30bd 100644
--- a/src/egl/generate/eglFunctionList.py
+++ b/src/egl/generate/eglFunctionList.py
@@ -195,5 +195,9 @@ EGL_FUNCTIONS = (
 
 # EGL_ANDROID_native_fence_sync
 _eglFunc("eglDupNativeFenceFDANDROID",   "display"),
+
+# EGL_EXT_image_dma_buf_import_modifiers
+_eglFunc("eglQueryDmaBufFormatsEXT", "display"),
+_eglFunc("eglQueryDmaBufModifiersEXT",   "display"),
 )
 
-- 
2.13.3

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev