Re: [Mesa-dev] [PATCH 2/2] glapi: remap_helper.py: remove unused argument 'es'

2015-06-21 Thread Emil Velikov
On 19/06/15 18:43, Dylan Baker wrote: This one is reviewed too. I'm on my phone and typing the reviewed by is hard though, so you'll have to copy from the last one. I'm currently in the process of writing a series to replace the mesa XML with the khronos XML, and as part of that I was

Re: [Mesa-dev] [PATCH 2/2] glapi: remap_helper.py: remove unused argument 'es'

2015-06-21 Thread Emil Velikov
On 19/06/15 12:29, Jose Fonseca wrote: I only did minor tweaks to these files, but the series LGTM. Being the ancient beast this is, I've merely picked of the last two people that had fun in the area. Never meant to target you/others in any way :-) Reviewed-by: Jose Fonseca

Re: [Mesa-dev] [PATCH 2/2] glapi: remap_helper.py: remove unused argument 'es'

2015-06-21 Thread Dylan Baker
Cleanups are definitely party of the plan. I'm doing three phases. First is going to mako for generation. Second is using the khronos XML. Finally I want to clean things up and hybridize for python 3 On Jun 21, 2015 7:34 AM, Emil Velikov emil.l.veli...@gmail.com wrote: On 19/06/15 18:43, Dylan

[Mesa-dev] [PATCH 2/2] glapi: remap_helper.py: remove unused argument 'es'

2015-06-19 Thread Emil Velikov
Identical to the previous commit - unused by neither the Autotools, Android or SCons build. XXX: There are no more users of gl_api.filter_functions_by_api(). Should we just nuke it ? Cc: Dylan Baker dylanx.c.ba...@intel.com Cc: Jose Fonseca jfons...@vmware.com Signed-off-by: Emil Velikov

Re: [Mesa-dev] [PATCH 2/2] glapi: remap_helper.py: remove unused argument 'es'

2015-06-19 Thread Jose Fonseca
I only did minor tweaks to these files, but the series LGTM. Reviewed-by: Jose Fonseca jfons...@vmware.com On 19/06/15 13:21, Emil Velikov wrote: Identical to the previous commit - unused by neither the Autotools, Android or SCons build. XXX: There are no more users of

Re: [Mesa-dev] [PATCH 2/2] glapi: remap_helper.py: remove unused argument 'es'

2015-06-19 Thread Dylan Baker
This one is reviewed too. I'm on my phone and typing the reviewed by is hard though, so you'll have to copy from the last one. I'm currently in the process of writing a series to replace the mesa XML with the khronos XML, and as part of that I was planning to rewrite the underlying representation