Re: [Mesa-dev] [PATCH 2/2] i965: Guard GetBufferSubData's streaming memcpy load with USE_SSE41

2017-08-12 Thread Kenneth Graunke
On Saturday, August 12, 2017 1:25:25 AM PDT Mauro Rossi wrote: > On Aug 11, 2017 5:14 PM, "Kenneth Graunke" wrote: > > On Thursday, August 10, 2017 11:50:30 PM PDT Tapani Pälli wrote: > > I do wonder what the target machine is (I haven't seen one that would > > not have

Re: [Mesa-dev] [PATCH 2/2] i965: Guard GetBufferSubData's streaming memcpy load with USE_SSE41

2017-08-12 Thread Mauro Rossi
On Aug 11, 2017 5:14 PM, "Kenneth Graunke" wrote: On Thursday, August 10, 2017 11:50:30 PM PDT Tapani Pälli wrote: > I do wonder what the target machine is (I haven't seen one that would > not have ARCH_X86_HAVE_SSE4_1 true, both 32bit and 64bit) but falling > back to

Re: [Mesa-dev] [PATCH 2/2] i965: Guard GetBufferSubData's streaming memcpy load with USE_SSE41

2017-08-11 Thread Kenneth Graunke
On Thursday, August 10, 2017 11:50:30 PM PDT Tapani Pälli wrote: > I do wonder what the target machine is (I haven't seen one that would > not have ARCH_X86_HAVE_SSE4_1 true, both 32bit and 64bit) but falling > back to memcpy makes perfect sense without USE_SSE4_1; > > Reviewed-by: Tapani Pälli

Re: [Mesa-dev] [PATCH 2/2] i965: Guard GetBufferSubData's streaming memcpy load with USE_SSE41

2017-08-11 Thread Emil Velikov
On 11 August 2017 at 12:31, Tapani Pälli wrote: > On 08/11/2017 02:23 PM, Grazvydas Ignotas wrote: >> >> On Fri, Aug 11, 2017 at 8:52 AM, Kenneth Graunke >> wrote: >>> >>> This should hopefully fix build issues on 32-bit Android-x86. >>> >>> Cc:

Re: [Mesa-dev] [PATCH 2/2] i965: Guard GetBufferSubData's streaming memcpy load with USE_SSE41

2017-08-11 Thread Tapani Pälli
On 08/11/2017 02:23 PM, Grazvydas Ignotas wrote: On Fri, Aug 11, 2017 at 8:52 AM, Kenneth Graunke wrote: This should hopefully fix build issues on 32-bit Android-x86. Cc: Mauro Rossi Cc: Tapani Pälli Bugzilla:

Re: [Mesa-dev] [PATCH 2/2] i965: Guard GetBufferSubData's streaming memcpy load with USE_SSE41

2017-08-11 Thread Grazvydas Ignotas
On Fri, Aug 11, 2017 at 8:52 AM, Kenneth Graunke wrote: > This should hopefully fix build issues on 32-bit Android-x86. > > Cc: Mauro Rossi > Cc: Tapani Pälli > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102050 >

Re: [Mesa-dev] [PATCH 2/2] i965: Guard GetBufferSubData's streaming memcpy load with USE_SSE41

2017-08-11 Thread Chris Wilson
Quoting Kenneth Graunke (2017-08-11 06:52:47) > This should hopefully fix build issues on 32-bit Android-x86. > > Cc: Mauro Rossi > Cc: Tapani Pälli > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102050 > --- >

Re: [Mesa-dev] [PATCH 2/2] i965: Guard GetBufferSubData's streaming memcpy load with USE_SSE41

2017-08-11 Thread Tapani Pälli
I do wonder what the target machine is (I haven't seen one that would not have ARCH_X86_HAVE_SSE4_1 true, both 32bit and 64bit) but falling back to memcpy makes perfect sense without USE_SSE4_1; Reviewed-by: Tapani Pälli On 08/11/2017 08:52 AM, Kenneth Graunke wrote:

[Mesa-dev] [PATCH 2/2] i965: Guard GetBufferSubData's streaming memcpy load with USE_SSE41

2017-08-10 Thread Kenneth Graunke
This should hopefully fix build issues on 32-bit Android-x86. Cc: Mauro Rossi Cc: Tapani Pälli Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102050 --- src/mesa/drivers/dri/i965/intel_buffer_objects.c | 2 ++ 1 file changed, 2