Re: [Mesa-dev] [PATCH 2/2] i965: Mark upload buffers with MAP_ASYNC and MAP_PERSISTENT.

2018-03-02 Thread Chris Wilson
Quoting Kenneth Graunke (2018-03-01 23:39:55)
> This should have no practical impact.  For the default uploader, we
> don't really care, but for others, we may want to append more data
> as the GPU is reading existing data, which means we need async and
> persistent flags.

Ok.

Reviewed-by: Chris Wilson 
-Chris
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev


[Mesa-dev] [PATCH 2/2] i965: Mark upload buffers with MAP_ASYNC and MAP_PERSISTENT.

2018-03-01 Thread Kenneth Graunke
This should have no practical impact.  For the default uploader, we
don't really care, but for others, we may want to append more data
as the GPU is reading existing data, which means we need async and
persistent flags.
---
 src/mesa/drivers/dri/i965/intel_upload.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/mesa/drivers/dri/i965/intel_upload.c 
b/src/mesa/drivers/dri/i965/intel_upload.c
index 53dff556873..e4297bf22b4 100644
--- a/src/mesa/drivers/dri/i965/intel_upload.c
+++ b/src/mesa/drivers/dri/i965/intel_upload.c
@@ -87,7 +87,9 @@ brw_upload_space(struct brw_uploader *upload,
if (!upload->bo) {
   upload->bo = brw_bo_alloc(upload->bufmgr, "streamed data",
 MAX2(upload->default_size, size), 4096);
-  upload->map = brw_bo_map(NULL, upload->bo, MAP_READ | MAP_WRITE);
+  upload->map = brw_bo_map(NULL, upload->bo,
+   MAP_READ | MAP_WRITE |
+   MAP_PERSISTENT | MAP_ASYNC);
}
 
upload->next_offset = offset + size;
-- 
2.16.1

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev