Re: [Mesa-dev] [PATCH 2/2] radv: do not lower 16-bit FMA

2019-04-01 Thread Samuel Pitoiset
On 4/1/19 4:02 PM, Bas Nieuwenhuizen wrote: This seems weird, do you know which tests are affected? All 16-bit fma tests. (I suspect what we really want to do is split into fmuladd and fma, and only lower fmuladd. If that does not work, something else is definitely going on) I will

Re: [Mesa-dev] [PATCH 2/2] radv: do not lower 16-bit FMA

2019-04-01 Thread Bas Nieuwenhuizen
This seems weird, do you know which tests are affected? (I suspect what we really want to do is split into fmuladd and fma, and only lower fmuladd. If that does not work, something else is definitely going on) On Mon, Mar 25, 2019 at 4:10 PM Samuel Pitoiset wrote: > > The lowering needs to be

[Mesa-dev] [PATCH 2/2] radv: do not lower 16-bit FMA

2019-03-25 Thread Samuel Pitoiset
The lowering needs to be disabled for sufficient precision to pass deqp-vk's 16-bit fma test on radv. Original patch from Rhys. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_shader.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/amd/vulkan/radv_shader.c