Re: [Mesa-dev] [PATCH 2/2] st/dri: replace format conversion functions with single mapping table

2018-06-07 Thread Marek Olšák
On Thu, Jun 7, 2018, 4:59 AM Lucas Stach wrote: > Hi Marek, > > thanks for the review. > > Am Samstag, den 26.05.2018, 00:36 -0400 schrieb Marek Olšák: > [...] > > > > > @@ -983,7 +760,7 @@ dri2_update_tex_buffer(struct dri_drawable > *drawable, > > > > > > static __DRIimage * > > >

Re: [Mesa-dev] [PATCH 2/2] st/dri: replace format conversion functions with single mapping table

2018-06-07 Thread Lucas Stach
Hi Marek, thanks for the review. Am Samstag, den 26.05.2018, 00:36 -0400 schrieb Marek Olšák: [...] > > > @@ -983,7 +760,7 @@ dri2_update_tex_buffer(struct dri_drawable *drawable, > > > >  static __DRIimage * > >  dri2_create_image_from_winsys(__DRIscreen *_screen, > > -                       

Re: [Mesa-dev] [PATCH 2/2] st/dri: replace format conversion functions with single mapping table

2018-05-25 Thread Marek Olšák
On Thu, May 17, 2018 at 6:50 AM, Lucas Stach wrote: > Each time I have to touch the buffer import/export functions in the dri > state tracker I get lost in the maze of functions converting between > DRI_IMAGE_FOURCC, DRI_IMAGE_FORMAT, DRI_IMAGE_COMPONENTS and pipe format.

[Mesa-dev] [PATCH 2/2] st/dri: replace format conversion functions with single mapping table

2018-05-17 Thread Lucas Stach
Each time I have to touch the buffer import/export functions in the dri state tracker I get lost in the maze of functions converting between DRI_IMAGE_FOURCC, DRI_IMAGE_FORMAT, DRI_IMAGE_COMPONENTS and pipe format. Rip it out and replace by a single table, which defines the correspondence between