Re: [Mesa-dev] [PATCH 2/2] st/mesa: simplify returning GL_VENDOR

2017-06-19 Thread Nicolai Hähnle
Reviewed-by: Nicolai Hähnle On 07.06.2017 22:09, Marek Olšák wrote: From: Marek Olšák --- src/mesa/state_tracker/st_cb_strings.c | 4 +--- src/mesa/state_tracker/st_context.h| 2 -- 2 files changed, 1 insertion(+), 5 deletions(-) diff

Re: [Mesa-dev] [PATCH 2/2] st/mesa: simplify returning GL_VENDOR

2017-06-13 Thread Marek Olšák
Rb, anyone? Thanks, Marek On Wed, Jun 7, 2017 at 10:09 PM, Marek Olšák wrote: > From: Marek Olšák > > --- > src/mesa/state_tracker/st_cb_strings.c | 4 +--- > src/mesa/state_tracker/st_context.h| 2 -- > 2 files changed, 1 insertion(+), 5

Re: [Mesa-dev] [PATCH 2/2] st/mesa: simplify returning GL_VENDOR

2017-06-07 Thread Ilia Mirkin
On Wed, Jun 7, 2017 at 4:42 PM, Ilia Mirkin wrote: > On Wed, Jun 7, 2017 at 4:34 PM, Marek Olšák wrote: >> On Wed, Jun 7, 2017 at 10:28 PM, Ilia Mirkin wrote: >>> On Wed, Jun 7, 2017 at 4:22 PM, Marek Olšák wrote:

Re: [Mesa-dev] [PATCH 2/2] st/mesa: simplify returning GL_VENDOR

2017-06-07 Thread Ilia Mirkin
On Wed, Jun 7, 2017 at 4:34 PM, Marek Olšák wrote: > On Wed, Jun 7, 2017 at 10:28 PM, Ilia Mirkin wrote: >> On Wed, Jun 7, 2017 at 4:22 PM, Marek Olšák wrote: >>> On Wed, Jun 7, 2017 at 10:12 PM, Ilia Mirkin wrote:

Re: [Mesa-dev] [PATCH 2/2] st/mesa: simplify returning GL_VENDOR

2017-06-07 Thread Marek Olšák
On Wed, Jun 7, 2017 at 10:28 PM, Ilia Mirkin wrote: > On Wed, Jun 7, 2017 at 4:22 PM, Marek Olšák wrote: >> On Wed, Jun 7, 2017 at 10:12 PM, Ilia Mirkin wrote: >>> This creates string lifetime issues... should probably document that

Re: [Mesa-dev] [PATCH 2/2] st/mesa: simplify returning GL_VENDOR

2017-06-07 Thread Ilia Mirkin
On Wed, Jun 7, 2017 at 4:22 PM, Marek Olšák wrote: > On Wed, Jun 7, 2017 at 10:12 PM, Ilia Mirkin wrote: >> This creates string lifetime issues... should probably document that >> the pointer returned by get_vendor and get_name are supposed to last >> for

Re: [Mesa-dev] [PATCH 2/2] st/mesa: simplify returning GL_VENDOR

2017-06-07 Thread Marek Olšák
On Wed, Jun 7, 2017 at 10:12 PM, Ilia Mirkin wrote: > This creates string lifetime issues... should probably document that > the pointer returned by get_vendor and get_name are supposed to last > for the lifetime of the screen. Was the lifetime of the string not always

Re: [Mesa-dev] [PATCH 2/2] st/mesa: simplify returning GL_VENDOR

2017-06-07 Thread Ilia Mirkin
This creates string lifetime issues... should probably document that the pointer returned by get_vendor and get_name are supposed to last for the lifetime of the screen. On Wed, Jun 7, 2017 at 4:09 PM, Marek Olšák wrote: > From: Marek Olšák > > --- >

[Mesa-dev] [PATCH 2/2] st/mesa: simplify returning GL_VENDOR

2017-06-07 Thread Marek Olšák
From: Marek Olšák --- src/mesa/state_tracker/st_cb_strings.c | 4 +--- src/mesa/state_tracker/st_context.h| 2 -- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/src/mesa/state_tracker/st_cb_strings.c b/src/mesa/state_tracker/st_cb_strings.c index