Re: [Mesa-dev] [PATCH 2/3] android: anv: add dependency on libnativewindow for O and later

2018-02-07 Thread Tapani Pälli
Thanks Mauro! Reviewed-by: Tapani Pälli On 02/08/2018 02:21 AM, Mauro Rossi wrote: How about introducing ANV_LIBRARIES (near to ANV_INCLUDES) and setting libdrm and libnativewindow there, then for each libanv just have the $(ANV_LIBRARIES)? IMO this would make it

Re: [Mesa-dev] [PATCH 2/3] android: anv: add dependency on libnativewindow for O and later

2018-02-07 Thread Mauro Rossi
> How about introducing ANV_LIBRARIES (near to ANV_INCLUDES) and setting > libdrm and libnativewindow there, then for each libanv just have the > $(ANV_LIBRARIES)? > > IMO this would make it cleaner to add new libs like we do here. In > Android-IA we've just had the libnativewindow include path

Re: [Mesa-dev] [PATCH 2/3] android: anv: add dependency on libnativewindow for O and later

2018-02-05 Thread Emil Velikov
On 5 February 2018 at 08:09, Tapani Pälli wrote: > Hi; > > > On 02/04/2018 11:57 PM, Mauro Rossi wrote: >> >> Similar to 90dd6e5 ("Android: egl: add dependency on libnativewindow") >> >> Fixes the following building errors: >> >> In file included from

Re: [Mesa-dev] [PATCH 2/3] android: anv: add dependency on libnativewindow for O and later

2018-02-05 Thread Tapani Pälli
Hi; On 02/04/2018 11:57 PM, Mauro Rossi wrote: Similar to 90dd6e5 ("Android: egl: add dependency on libnativewindow") Fixes the following building errors: In file included from external/mesa/src/intel/vulkan/gen7_cmd_buffer.c:30: In file included from

[Mesa-dev] [PATCH 2/3] android: anv: add dependency on libnativewindow for O and later

2018-02-04 Thread Mauro Rossi
Similar to 90dd6e5 ("Android: egl: add dependency on libnativewindow") Fixes the following building errors: In file included from external/mesa/src/intel/vulkan/gen7_cmd_buffer.c:30: In file included from external/mesa/src/intel/vulkan/anv_private.h:72: